Skip to content

Undo breaking change for OptionsWrapper<T>.Remove(string) and Add(string, TOptions) #2983

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Eilon opened this issue Mar 21, 2018 · 1 comment
Assignees
Labels
bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed

Comments

@Eilon
Copy link
Member

Eilon commented Mar 21, 2018

A breaking change was introduced in 2.1 for the methods on OptionsWrapper<T>: Remove(string) and Add(string, TOptions).

This breaking change doesn't seem worthwhile, given how trivial it is to just leave the unused APIs there.

Guidelines on how to obsolete members is here: https://github.com/aspnet/Home/wiki/Engineering-guidelines#breaking-changes

cc @HaoK @ajcvickers

@Eilon Eilon added bug This issue describes a behavior which is not expected - a bug. 1 - Ready labels Mar 21, 2018
@Eilon Eilon added this to the 2.1.0-preview2 milestone Mar 21, 2018
@Eilon Eilon changed the title Undo breaking change for OptionsWrapper<T>.Remove(string) Undo breaking change for OptionsWrapper<T>.Remove(string) and Add(string, TOptions) Mar 21, 2018
@Eilon
Copy link
Member Author

Eilon commented Mar 21, 2018

See discussion here: aspnet/Options#251 (comment)

@HaoK HaoK self-assigned this Mar 26, 2018
@HaoK HaoK added Done This issue has been fixed and removed 1 - Ready labels Mar 26, 2018
@HaoK HaoK closed this as completed Mar 26, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

2 participants