CI: Add windows-latest to job matrix
#519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
==========================================
+ Coverage 89.60% 89.77% +0.17%
==========================================
Files 8 8
Lines 577 577
==========================================
+ Hits 517 518 +1
+ Misses 60 59 -1
Continue to review full report at Codecov.
|
avdv
force-pushed
the
ci-on-windows
branch
2 times, most recently
from
c66711b
to
1431839
Compare
When running on Windows this test failed with:
```
Failures:
1) ColorLS::Flags symlinked directory with trailing separator shows the file in the linked directory
Failure/Error: expect { subject }.to output(/yaml_sort_checker.rb/).to_stdout
expected block to output /yaml_sort_checker.rb/ to stdout, but output " Supportlink \n"
Diff:
@@ -1 +1 @@
-/yaml_sort_checker.rb/
+ Supportlink
# ./spec/color_ls/flags_spec.rb:329:in `block (3 levels) in <top (required)>'
```
This is due to the different handling of paths to a symlink with a trailing
slash / backslash.
`File.lstat(x).directory?` returns
OS | x | value
----------------------------
Windows | symlink\ | false
Windows | symlink | false
Linux | symlink/ | true
Linux | symlink | false
This could be fixed in colorls by handling a trailing (back)slash specifically,
but I am unsure whether that is the right thing to do on Windows.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run tests on Windows, too.