Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CI: Add windows-latest to job matrix #519

Merged
merged 4 commits into from
Apr 29, 2022
Merged

CI: Add windows-latest to job matrix #519

merged 4 commits into from
Apr 29, 2022

Commits on Apr 29, 2022

  1. Release version 1.4.6

    @avdv
    avdv committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    00cd57c View commit details
    Browse the repository at this point in the history

  2. CI: Add windows-latest to job matrix

    @avdv
    avdv committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    7a88177 View commit details
    Browse the repository at this point in the history

  3. Fix "shows the file in the linked directory" test on Windows 

    When running on Windows this test failed with:

```
Failures:

  1) ColorLS::Flags symlinked directory with trailing separator shows the file in the linked directory
     Failure/Error: expect { subject }.to output(/yaml_sort_checker.rb/).to_stdout

       expected block to output /yaml_sort_checker.rb/ to stdout, but output "       Supportlink \n"
       Diff:
       @@ -1 +1 @@
       -/yaml_sort_checker.rb/
       +       Supportlink
     # ./spec/color_ls/flags_spec.rb:329:in `block (3 levels) in <top (required)>'
```

This is due to the different handling of paths to a symlink with a trailing
slash / backslash.

`File.lstat(x).directory?` returns

OS      |     x    | value
----------------------------
Windows | symlink\ | false
Windows | symlink  | false
Linux   | symlink/ | true
Linux   | symlink  | false

This could be fixed in colorls by handling a trailing (back)slash specifically,
but I am unsure whether that is the right thing to do on Windows.
    @avdv
    avdv committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    6d8e229 View commit details
    Browse the repository at this point in the history

  4. Explicitly use bash (for Windows)

    @avdv
    avdv committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    8c73bd0 View commit details
    Browse the repository at this point in the history