Add the support of testing on multiple datasets after training on one dataset. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-zzh
changed the title
suzhoum
reviewed
Dec 14, 2023
| @@ -193,6 +193,7 @@ def run( | |||
| "problem_type": train_data.problem_type, | |||
| "presets": params.pop("presets", None), | |||
| "path": os.path.join(benchmark_dir, "models"), | |||
| "eval_metric": val_data.metric, | |||
There was a problem hiding this comment.
val_data might not be available for all datasets so we need to handle that.
There was a problem hiding this comment.
How about adding these lines:
if val_data is not None:
predictor_args["eval_metric"] = val_data.metric
added 3 commits
December 16, 2023 03:08
suzhoum
approved these changes
Dec 19, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.