eupgrade/cancun: verify no blobs in header #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Jul 24, 2024
Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
ARR4N
requested changes
Jul 25, 2024
ceyonur
reviewed
Jul 25, 2024
ceyonur
approved these changes
Jul 25, 2024
ARR4N
reviewed
Jul 31, 2024
ARR4N
approved these changes
Aug 2, 2024
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* eupgrade/cancun: verify no blobs in header * Update consensus/dummy/consensus.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> * fix ut * review comments * add UT * use require * fix ut * update UT to make a blob TX --------- Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It is safer to disallow blobs in block verification, since there is no builder/mempool.
How this works
Enforces a 0 blob gas, which implies no blobs (and is easy to check from the header without a larger code change)
How this was tested
CI