Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

eupgrade/cancun: verify no blobs in header #611

Merged
merged 10 commits into from
Aug 2, 2024
Merged

eupgrade/cancun: verify no blobs in header #611

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e4b0cf8
eupgrade/cancun: verify no blobs in header
darioush Jul 24, 2024
4ec90b0
Update consensus/dummy/consensus.go
darioush Jul 24, 2024
16a9f01
fix ut
darioush Jul 24, 2024
936faa4
Merge branch 'verify-no-blobs' of github.com:ava-labs/coreth into ver…
darioush Jul 24, 2024
6190ed4
review comments
darioush Jul 25, 2024
c53a5ea
add UT
darioush Jul 26, 2024
b069f27
use require
darioush Jul 26, 2024
34d6f07
fix ut
darioush Jul 26, 2024
2349fd6
Merge branch 'master' of github.com:ava-labs/coreth into verify-no-blobs
darioush Jul 29, 2024
3f2a17a
update UT to make a blob TX
darioush Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions consensus/dummy/consensus.go
View file
Open in desktop
darioush marked this conversation as resolved.
Show resolved Hide resolved
ceyonur marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,9 @@ func (self *DummyEngine) verifyHeader(chain consensus.ChainHeaderReader, header
if err := eip4844.VerifyEIP4844Header(parent, header); err != nil {
return err
}
if *header.BlobGasUsed > 0 { // VerifyEIP4844Header ensures excessBlobGas is non-nil
darioush marked this conversation as resolved.
Show resolved Hide resolved
return fmt.Errorf("blobs not enabled on avalanche networks: have %d, expected 0", *header.BlobGasUsed)
darioush marked this conversation as resolved.
Show resolved Hide resolved
}
}
return nil
}
Expand Down
3 changes: 2 additions & 1 deletion core/state_processor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ func TestStateProcessorErrors(t *testing.T) {
want: "could not apply tx 0 [0x6c11015985ce82db691d7b2d017acda296db88b811c3c60dc71449c76256c716]: max fee per gas less than block base fee: address 0x71562b71999873DB5b286dF957af199Ec94617F7, maxFeePerGas: 1, baseFee: 225000000000",
},
} {
block := GenerateBadBlock(gspec.ToBlock(), dummy.NewCoinbaseFaker(), tt.txs, gspec.Config)
// FullFaker used to skip header verification that enforces no blobs.
block := GenerateBadBlock(gspec.ToBlock(), dummy.NewFullFaker(), tt.txs, gspec.Config)
_, err := blockchain.InsertChain(types.Blocks{block})
if err == nil {
t.Fatal("block imported without errors")
Expand Down
3 changes: 2 additions & 1 deletion internal/ethapi/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,8 @@ func setupReceiptBackend(t *testing.T, genBlocks int) (*testBackend, []common.Ha
// Set the terminal total difficulty in the config
// genesis.Config.TerminalTotalDifficulty = big.NewInt(0)
// genesis.Config.TerminalTotalDifficultyPassed = true
backend := newTestBackend(t, genBlocks, genesis, dummy.NewCoinbaseFaker(), func(i int, b *core.BlockGen) {
// FullFaker used to skip header verification that enforces no blobs.
backend := newTestBackend(t, genBlocks, genesis, dummy.NewFullFaker(), func(i int, b *core.BlockGen) {
var (
tx *types.Transaction
err error
Expand Down
Loading