Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: make dependabot work on all projects except src.gen/ #5601

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

hayemaxi
Copy link
Contributor

@hayemaxi hayemaxi commented Sep 16, 2024

This attempts to fix our dependabot issue but I am not sure what the best way to test this is other than committing it and seeing what happens.

Problem (as I understand it, may be incorrect): Dependabot wants to update deps in src.gen/, but this is managed separately and can cause things to break. There is no exclude dirs option in dependabot. So, we limit the dependabot to packages/core only which doesn't paint the full picture of all of our dependencies AND since this is a monorepo where the package-lock.json lives in the root, it cannot be updated. This effectively bricks dependabot and makes the PRs nothing more than a reminder.

Solution: Use this 'workaround' to exclude a directory so that dependabot can update the deps of all of our subprojects and the root directory without touching src.gen/.
Hack from: dependabot/dependabot-core#4364

MAY have to follow up with removing versioning-strategy: 'increase', (added because of dependabot/dependabot-core#4993)


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

This attempts to fix our dependabot issue but I am not sure what the best way to test this is other than committing it and seeing what happens.

Problem (as I understand it, may be incorrect): Dependabot wants to update deps in src.gen/, but this is managed separately and can cause things to break. There is no exclude dirs option in dependabot. So, we limit the dependabot to packages/core only which doesn't paint the full picture of all of our dependencies AND since this is a monorepo where the package-lock.json lives in the root, it cannot be updated. This effectively bricks dependabot and makes the PRs nothing more than a reminder.

Solution: Use this 'workaround' to exclude a directory so that dependabot can update the deps of all of our subprojects and the root directory without touching src.gen/.
Hack from: dependabot/dependabot-core#4364

MAY have to follow up with `versioning-strategy: 'increase'`, see dependabot/dependabot-core#4993
@hayemaxi hayemaxi requested a review from a team as a code owner September 16, 2024 18:41
@justinmk3 justinmk3 changed the title config(dependabot): make dependabot work on all projects except src.gen/ ci: make dependabot work on all projects except src.gen/ Sep 16, 2024
@justinmk3 justinmk3 merged commit 910b3a3 into aws:master Sep 16, 2024
20 of 34 checks passed
@hayemaxi hayemaxi deleted the dependabot2 branch January 22, 2025 19:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants