-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Ignore manifests in specific subdirectories #4364
Comments
Need to generally be able to specify sub-folders to ignore |
@jurre I think this would be quite nice. I also have a test folder with some old abandoned test framework. It has its own package.json. Depandabot is quite crazy about it, even it is not a production code. |
+1 for this feature! I have exactly the same use case as @jirikrepl and would be very happy if I could exclude specific sub directories. There's a discussion about this on SO already: https://stackoverflow.com/questions/65275433/can-i-exclude-directories-from-github-dependabot |
Dependabot is being silly and trying to upgrade older versions in the test requirements files to the latest. That's not what we want. Ideally, we would instruct Dependabot to ignore those files, but that capability is not available. See dependabot/dependabot-core#4364
Dependabot is being silly and trying to upgrade older versions in the test requirements files to the latest. That's not what we want. Ideally, we would instruct Dependabot to ignore those files, but that capability is not available. See dependabot/dependabot-core#4364
+1 here. In https://github.com/stryker-mutator/stryker-js, we've defined 40+ end to end tests in the Now I've noticed that the old version is not so old anymore, since dependabot came a long and it got merged automatically 😢. |
This feature would be great! Some monorepo refactors use outdated code in a sandboxed directory, and dependabot can be annoying when that code is very much dead (and intentionally so). Yes, you can/should also use a branch/tag, but not everyone prefers to do so. |
Not being able to ignore directories is quite annoying. I have some legacy code in legacy directories, that is only used for reference purposes. It never runs anywhere. But I'm slammed with constant alerts & PRs for it. |
We have the same problem. We have a documentation folder with dependencies that really don't need to be checked. Ignoring folder would really be a great and needed feature |
Yeah this seems like a real basic configuration option, sad to see that it is not implemented. Happy to help add this if anyone knows where I should get started! |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Also on a monorepo and we have a directory where we have some hiring tests, currently 300 alerts from dependabot, all in recruitment |
The strangest thing. I've changed our dependabot configuration to only scan the version: 2
updates:
- package-ecosystem: npm
directory: '/packages' But now it isn't searching any of our packages (and apparently hasn't been since February, which is why users are reporting issues 😢). Can anyone explain what's going on? Apparently using |
@nicojs could you try |
I have a workaround that suits my use case, hopefully this could help others.
I was required to only bump dependencies for
The above includes the undesired
|
It's been a while since this update, do you have any update @carogalvin? |
👋 new Dependabot PM enters the chat -- I work closely with @carogalvin! This feature is not on our roadmap, but grouped of security updates that Caro referenced has shipped, as well as multi-directory keys for the dependabot.yml and glob support. Used in conjunction give a decent way to bypass manifests in specific subdirectories (by grouping and globbing to the next-lowest directory using the I don't have a timeline on ignore conditions right now. |
This definitely should be implemented! So helpful for monorepos 😭 |
It will be also useful for regular repo where the aim is to tests integrations with older components' versions. On those repos, some manifests must be updated, where other must not. |
This attempts to fix our dependabot issue but I am not sure what the best way to test this is other than committing it and seeing what happens. Problem (as I understand it, may be incorrect): Dependabot wants to update deps in src.gen/, but this is managed separately and can cause things to break. There is no exclude dirs option in dependabot. So, we limit the dependabot to packages/core only which doesn't paint the full picture of all of our dependencies AND since this is a monorepo where the package-lock.json lives in the root, it cannot be updated. This effectively bricks dependabot and makes the PRs nothing more than a reminder. Solution: Use this 'workaround' to exclude a directory so that dependabot can update the deps of all of our subprojects and the root directory without touching src.gen/. Hack from: dependabot/dependabot-core#4364 MAY have to follow up with `versioning-strategy: 'increase'`, see dependabot/dependabot-core#4993
This attempts to fix our dependabot issue but I am not sure what the best way to test this is other than committing it and seeing what happens. Problem (as I understand it, may be incorrect): Dependabot wants to update deps in src.gen/, but this is managed separately and can cause things to break. There is no exclude dirs option in dependabot. So, we limit the dependabot to packages/core only which doesn't paint the full picture of all of our dependencies AND since this is a monorepo where the package-lock.json lives in the root, it cannot be updated. This effectively bricks dependabot and makes the PRs nothing more than a reminder. Solution: Use this 'workaround' to exclude a directory so that dependabot can update the deps of all of our subprojects and the root directory without touching src.gen/. Hack from: dependabot/dependabot-core#4364 MAY have to follow up with `versioning-strategy: 'increase'`, see dependabot/dependabot-core#4993
This attempts to fix our dependabot issue but I am not sure what the best way to test this is other than committing it and seeing what happens. Problem (as I understand it, may be incorrect): Dependabot wants to update deps in src.gen/, but this is managed separately and can cause things to break. There is no exclude dirs option in dependabot. So, we limit the dependabot to packages/core only which doesn't paint the full picture of all of our dependencies AND since this is a monorepo where the package-lock.json lives in the root, it cannot be updated. This effectively bricks dependabot and makes the PRs nothing more than a reminder. Solution: Use this 'workaround' to exclude a directory so that dependabot can update the deps of all of our subprojects and the root directory without touching src.gen/. Hack from: dependabot/dependabot-core#4364 MAY have to follow up with `versioning-strategy: 'increase'`, see dependabot/dependabot-core#4993
@carlincherry does the dependabot globbing algo natively support excludes? I know some glob implementations do: https://www.baeldung.com/linux/globbing-exclude-pattern#using-negation-operators |
@cmeyertons unfortunately not - the Dependabot globbing algo doesn't natively support excludes 😿 |
@carlincherry gosh seems like a super small non breaking enhancement with minimal additional overhead to finally close out this issue….. would be a nice feather in a cap for a new Dependabot PM 😄 |
Glob excludes wouldn't fix this for us. I did some tests with the |
good guy dependabot making sure we move our experiments and PoCs (frozen as documentation) away from our production code... /s I suppose it's tidier, but dependabot... don't touch my garbage!!! |
It is not a mono repo but quite a large one, where Dependabot is timing out on a single project. I don't want to remove Dependabot, but being stuck on that single project creates a different .sln file (for NuGet packages), which is a nasty workaround, or it doesn't run Dependabot. If there was a way to exclude a folder, this would be a no brainer. |
I have some monorepo in monorepo setup, but I do not want the dependebot scan a sub monorepo folder.
The text was updated successfully, but these errors were encountered: