eth/tracers: fix system transaction and prestate tracer after Venoki (#…

…565)

* core: skip gas check for system transaction when tracing

As system transaction has 0 gas price, it does not pass the check that gas price
must be greater or equal to base fee when base fee is not 0. Skip gas check for
system transaction in TransitionDb, system transaction will go through
TransitionDb only in tracing path not in normal transaction processing path.

* eth/tracers: fix balance tracking in prestate tracer after Venoki

Add ronin treasury to balance tracking after Venoki as base fee and blob fee are
transferred to it. The blob fee is subtracted from sender's balance added to
ronin treasury's balance in buyGas which is before the CaptureStart hook. So we
need to fix these balances up to get the correct balance before the transaction
happens.

core/state_transition.go

@@ -420,8 +420,10 @@ func (st *StateTransition) TransitionDb() (*ExecutionResult, error) {
 	// 6. caller has enough balance to cover asset transfer for **topmost** call
 
 	// Check clauses 1-3, buy gas if everything is correct
-	if err := st.preCheck(); err != nil {
-		return nil, err
+	if !st.evm.Config.IsSystemTransaction {
+		if err := st.preCheck(); err != nil {
+			return nil, err
+		}
 	}
 
 	if tracer := st.evm.Config.Tracer; tracer != nil {

eth/tracers/native/prestate.go

@@ -27,6 +27,7 @@ import (
 	"github.com/ethereum/go-ethereum/core/vm"
 	"github.com/ethereum/go-ethereum/crypto"
 	"github.com/ethereum/go-ethereum/eth/tracers"
+	"github.com/ethereum/go-ethereum/params"
 )
 
 //go:generate go run github.com/fjl/gencodec -type account -field-override accountMarshaling -out gen_account_json.go
@@ -101,6 +102,10 @@ func (t *prestateTracer) CaptureStart(env *vm.EVM, from common.Address, to commo
 	t.lookupAccount(from)
 	t.lookupAccount(to)
 	t.lookupAccount(env.Context.Coinbase)
+	treasury := env.ChainConfig().RoninTreasuryAddress
+	if treasury != nil {
+		t.lookupAccount(*treasury)
+	}
 
 	// The recipient balance includes the value transferred.
 	toBal := new(big.Int).Sub(t.pre[to].Balance, value)
@@ -117,6 +122,17 @@ func (t *prestateTracer) CaptureStart(env *vm.EVM, from common.Address, to commo
 	} else {
 		diffFromBal.Add(diffFromBal, consumedGas)
 	}
+	// At this time, the blob fee is already subtracted from sender and added to treasury.
+	// So we need to add blob fee back to sender and subtract from treasury to get the correct
+	// pre-tx balance.
+	if len(env.BlobHashes) > 0 {
+		blobFee := new(big.Int).Mul(big.NewInt(int64(len(env.BlobHashes)*params.BlobTxBlobGasPerBlob)), env.Context.BlobBaseFee)
+		diffFromBal.Add(diffFromBal, blobFee)
+		if treasury != nil {
+			t.pre[*treasury].Balance = new(big.Int).Sub(t.pre[*treasury].Balance, blobFee)
+		}
+	}
+
 	fromBal.Add(fromBal, diffFromBal)
 	t.pre[from].Balance = fromBal
 	t.pre[from].Nonce--