This repository has been archived by the owner on Feb 18, 2025. It is now read-only.
eth/tracers: fix system transaction and prestate tracer after Venoki #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As system transaction has 0 gas price, it does not pass the check that gas price must be greater or equal to base fee when base fee is not 0. Skip gas check for system transaction in TransitionDb, system transaction will go through TransitionDb only in tracing path not in normal transaction processing path.
Add ronin treasury to balance tracking after Venoki as base fee and blob fee are transferred to it. The blob fee is subtracted from sender's balance added to ronin treasury's balance in buyGas which is before the CaptureStart hook. So we need to fix these balances up to get the correct balance before the transaction happens.
andicrypt
approved these changes
Sep 10, 2024
minh-bq
added a commit
that referenced
this pull request
Sep 16, 2024
…565) * core: skip gas check for system transaction when tracing As system transaction has 0 gas price, it does not pass the check that gas price must be greater or equal to base fee when base fee is not 0. Skip gas check for system transaction in TransitionDb, system transaction will go through TransitionDb only in tracing path not in normal transaction processing path. * eth/tracers: fix balance tracking in prestate tracer after Venoki Add ronin treasury to balance tracking after Venoki as base fee and blob fee are transferred to it. The blob fee is subtracted from sender's balance added to ronin treasury's balance in buyGas which is before the CaptureStart hook. So we need to fix these balances up to get the correct balance before the transaction happens.
minh-bq
added a commit
that referenced
this pull request
Sep 16, 2024
…565) * core: skip gas check for system transaction when tracing As system transaction has 0 gas price, it does not pass the check that gas price must be greater or equal to base fee when base fee is not 0. Skip gas check for system transaction in TransitionDb, system transaction will go through TransitionDb only in tracing path not in normal transaction processing path. * eth/tracers: fix balance tracking in prestate tracer after Venoki Add ronin treasury to balance tracking after Venoki as base fee and blob fee are transferred to it. The blob fee is subtracted from sender's balance added to ronin treasury's balance in buyGas which is before the CaptureStart hook. So we need to fix these balances up to get the correct balance before the transaction happens.
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Sep 24, 2024
…xieinfinity#565) * core: skip gas check for system transaction when tracing As system transaction has 0 gas price, it does not pass the check that gas price must be greater or equal to base fee when base fee is not 0. Skip gas check for system transaction in TransitionDb, system transaction will go through TransitionDb only in tracing path not in normal transaction processing path. * eth/tracers: fix balance tracking in prestate tracer after Venoki Add ronin treasury to balance tracking after Venoki as base fee and blob fee are transferred to it. The blob fee is subtracted from sender's balance added to ronin treasury's balance in buyGas which is before the CaptureStart hook. So we need to fix these balances up to get the correct balance before the transaction happens.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As system transaction has 0 gas price, it does not pass the check that gas price
must be greater or equal to base fee when base fee is not 0. Skip gas check for
system transaction in TransitionDb, system transaction will go through
TransitionDb only in tracing path not in normal transaction processing path.
Add ronin treasury to balance tracking after Venoki as base fee and blob fee are
transferred to it. The blob fee is subtracted from sender's balance added to
ronin treasury's balance in buyGas which is before the CaptureStart hook. So we
need to fix these balances up to get the correct balance before the transaction
happens.