Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Support ESLint 7.x #43

Closed
wants to merge 1 commit into from
Closed

feat: Support ESLint 7.x #43

wants to merge 1 commit into from

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented May 8, 2020

ESLint v7.0.0 is released 🎉

devDependencies should be compatible with ESLint 7 too before we can merge this one:


BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x

Closes #44

BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x
@codecov-io
Copy link

codecov-io commented May 8, 2020

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           51        51           
=========================================
  Hits            51        51           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbe2bc...3297a56. Read the comment docs.

@MichaelDeBoey MichaelDeBoey marked this pull request as draft May 8, 2020 21:50
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review May 9, 2020 02:04
@AdrieanKhisbe
Copy link
Collaborator

@MichaelDeBoey I'm going to have a look :)

But first I think I'll set up integration tests to ensure that eslint-plugin-json still works for eslint versions prior to the new 7 major if possible.

If it's not possible, and to avoid to support multiple version lines, it would be preferable IMO to make land #39 and #41 first, and address of #37 and #42

Copy link
Collaborator

@AdrieanKhisbe AdrieanKhisbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelDeBoey after having worked on #46 to test different eslint major ranges,
it seems to be that this PR is not necessary to have plugin work on eslint-V7: it is already compatible, cf this build

(PS: typo was meant in original message referring this PR #43 rather than #46 🙈 )

@AdrieanKhisbe AdrieanKhisbe mentioned this pull request May 20, 2020
@MichaelDeBoey
Copy link
Contributor Author

Tested by #46

@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch May 20, 2020 17:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
3 participants