Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Integration test against several eslint majors #46

Conversation

AdrieanKhisbe
Copy link
Collaborator

This PR improves tests and CI to ensure plugin working for different eslint major ranges. (mentionned in #43 (comment))

So far, eslint v6 is supported for all supported node ranges (8 to 14 (14 introduced in this PR)).
and eslint v7 supported started from node 10. (which is an eslint v7 prerequesite)

Took the opportunity to split the build into several jobs.


Ps: Some work might be necessary to see support status of v5, but as more complicated than expected, and far less important, I let it aside for the time being.

@AdrieanKhisbe AdrieanKhisbe force-pushed the integration-test-against-several-eslint-majors branch from d897df4 to ac1f44e Compare May 20, 2020 13:52
@AdrieanKhisbe
Copy link
Collaborator Author

(I just rebased to fix conflict induced by #41 :))

@AdrieanKhisbe AdrieanKhisbe merged commit 4499104 into azeemba:master May 20, 2020
@AdrieanKhisbe AdrieanKhisbe deleted the integration-test-against-several-eslint-majors branch May 20, 2020 17:18
@AdrieanKhisbe AdrieanKhisbe mentioned this pull request May 20, 2020
@MichaelDeBoey MichaelDeBoey mentioned this pull request May 20, 2020
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants