fix(Scripts/ICC): Fix crash in npc_darnavan when killer is nil. (#21438)

azerothcore · Feb 14, 2025 · db9b4cf · db9b4cf
1 parent db49562
commit db9b4cf
Showing 1 changed file with 17 additions and 10 deletions.
diff --git a/src/server/scripts/Northrend/IcecrownCitadel/boss_lady_deathwhisper.cpp b/src/server/scripts/Northrend/IcecrownCitadel/boss_lady_deathwhisper.cpp
@@ -1021,18 +1021,25 @@ class npc_darnavan : public CreatureScript
         void JustDied(Unit* killer) override
         {
             events.Reset();
-            if (Player* owner = killer->GetCharmerOrOwnerPlayerOrPlayerItself())
+
+            if (!killer)
+                return;
+
+            Player* owner = killer->GetCharmerOrOwnerPlayerOrPlayerItself();
+            if (!owner)
+                return;
+
+            Group* group = owner->GetGroup();
+            if (!group)
             {
-                if (Group* group = owner->GetGroup())
-                {
-                    for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next())
-                        if (Player* member = itr->GetSource())
-                            if (member->IsInMap(owner))
-                                member->FailQuest(QUEST_DEPROGRAMMING);
-                }
-                else
-                    owner->FailQuest(QUEST_DEPROGRAMMING);
+                owner->FailQuest(QUEST_DEPROGRAMMING);
+                return;
             }
+
+            for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next())
+                if (Player* member = itr->GetSource())
+                    if (member->IsInMap(owner))
+                        member->FailQuest(QUEST_DEPROGRAMMING);
         }
 
         void MovementInform(uint32 type, uint32 id) override