Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(Scripts/ICC): Fix crash in npc_darnavan when killer is nil. #21438

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

walkline
Copy link
Contributor

Crashlog:

Thread 11 "worldserver" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffda535640 (LWP 338487)]
0x00005555579c2c9d in Object::GetGuidValue (this=0x0, index=<optimized out>) at /opt/wotlk_prod/src/server/game/Entities/Object/Object.cpp:339
339    ASSERT(index + 1 < m_valuesCount || PrintIndexError(index, false));
#0  0x00005555579c2c9d in Object::GetGuidValue (this=0x0, index=<optimized out>) at /opt/wotlk_prod/src/server/game/Entities/Object/Object.cpp:339
#1  0x0000555557cd2963 in Unit::GetCharmerGUID (this=0x0) at /opt/wotlk_prod/src/server/game/Entities/Unit/Unit.h:690
#2  Unit::GetCharmerOrOwnerGUID (this=0x0) at /opt/wotlk_prod/src/server/game/Entities/Unit/Unit.h:1229
#3  Unit::GetCharmerOrOwnerPlayerOrPlayerItself (this=0x0) at /opt/wotlk_prod/src/server/game/Entities/Unit/Unit.cpp:10669
#4  0x000055555684d498 in npc_darnavan::npc_darnavanAI::JustDied (this=0x614000e98c40, killer=0x0) at /opt/wotlk_prod/src/server/scripts/Northrend/IcecrownCitadel/boss_lady_deathwhisper.cpp:1024
#5  0x0000555557cd4e2e in Unit::Kill (killer=<optimized out>, victim=0x626052eb4100, durabilityLoss=<optimized out>, attackType=<optimized out>, spellProto=<optimized out>, spell=<optimized out>) at /opt/wotlk_prod/src/server/game/Entities/Unit/Unit.cpp:18007
#6  0x0000555557cc931d in Unit::DealDamage (attacker=<optimized out>, victim=<optimized out>, damage=<optimized out>, cleanDamage=0x7fffc6e73c90, damagetype=<optimized out>, damageSchoolMask=<optimized out>, spellProto=<optimized out>, durabilityLoss=<optimized out>, damageSpell=<optimized out>) at /opt/wotlk_prod/src/server/game/Entities/Unit/Unit.cpp:1052
#7  0x0000555558ad3655 in AuraEffect::HandlePeriodicDamageAurasTick (this=<optimized out>, target=0xffffffffffffffff, caster=<optimized out>) at /opt/wotlk_prod/src/server/game/Spells/Auras/SpellAuraEffects.cpp:6743

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added Script file-cpp Used to trigger the matrix build labels Feb 13, 2025
@sudlud sudlud merged commit db9b4cf into azerothcore:master Feb 14, 2025
8 checks passed
skelUA pushed a commit to skelUA/wotlk that referenced this pull request Feb 14, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
file-cpp Used to trigger the matrix build Script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants