Support ECL 1.6 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set domain on filter constraint - Remove QL-style domain qualifier from filters - Add definition status filter - Allow sub-expressions in filters (where previously only single concept references or whitespace-separated ID lists were accepted) - Accept 0 and 1 in component status filter
If regular expression parsing fails, the original String passed along in ValueConverterWithValueException still gets set on the model.
- Validate acceptability tokens ("prefer" and "accept")
- Validate definition status tokens ("primitive" and "defined")
- Allow empty string in effective time filters
- Check consistency of filter constraint and contained filter domains
...of acceptability tokens to concept identifiers
- Component filters should consult the container FilterConstraint to determine the domain - The default domain should be "description" for ECL 1.6
- Change QL-style filter domains to single-letter filter constraint domains - Add test cases for numeric component status values - Add test cases for definition status filter - Add test case for empty effective time literal
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request updates the grammar definition and related files to make it compatible with version 1.6 of the specification. See this SNOMED International Confluence page🌍 for differences.