Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Introduce LS changes related to external function change #14751

Closed
MaryamZi opened this issue Mar 28, 2019 · 2 comments · Fixed by #15651
Closed

Introduce LS changes related to external function change #14751

MaryamZi opened this issue Mar 28, 2019 · 2 comments · Fixed by #15651
Assignees
@nadeeshaan @roonyh @NipunaMarcus
Labels
Area/SyntaxHighlighting Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Task

Comments

@MaryamZi
Copy link
Member

MaryamZi commented Mar 28, 2019 •
edited by nadeeshaan
Loading

Description:
External function definition will be changed with #14608. Creating this issue to track LS related changes required.

Current syntax:

extern function externFunction();

New syntax:

function externFunction() = external;

Related Issues (optional):
#14596
#15584
@MaryamZi MaryamZi added the Team/LanguageServer Language Server Implementation related issues. #Compiler label Mar 28, 2019
@NipunaMarcus
Copy link
Contributor

@roonyh We need to fix the syntax highlighting as well for this ...

@NipunaMarcus NipunaMarcus mentioned this issue Mar 29, 2019
Merged
@MaryamZi
Copy link
Member Author

@nadeeshaan, as discussed offline we've temporarily commented out the "suggestionAfterExtern" test with 56ae017.

@anupama-pathirage anupama-pathirage added the Team/CompilerFETools Semantic API, Formatter, Shell label Apr 30, 2019
nadeeshaan added a commit to nadeeshaan/ballerina that referenced this issue Jun 11, 2019
@nadeeshaan
Fix Issues ballerina-platform#15503 and ballerina-platform#14751
bd243bf
@nadeeshaan nadeeshaan mentioned this issue Jun 11, 2019
Merged
14 tasks
@kaviththiranga kaviththiranga mentioned this issue Jun 13, 2019
Closed
32 tasks
nadeeshaan added a commit that referenced this issue Jun 13, 2019
@nadeeshaan
Merge pull request #15651 from nadeeshaan/dev-branch
9396d82 
Fix Issues #15503, #14751 and #14346
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nadeeshaan nadeeshaan

@roonyh roonyh

@NipunaMarcus NipunaMarcus

Labels
Area/SyntaxHighlighting Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Issues #15503, #14751 and #14346 nadeeshaan/ballerina
6 participants
@nadeeshaan @kaviththiranga @roonyh @MaryamZi @NipunaMarcus @anupama-pathirage