Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Function completion inserts params with default values as well #15503

Closed
pubudu91 opened this issue Jun 3, 2019 · 1 comment · Fixed by #15651
Closed

Function completion inserts params with default values as well #15503

pubudu91 opened this issue Jun 3, 2019 · 1 comment · Fixed by #15651
Assignees
@nadeeshaan
Labels
Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Improvement

Comments

@pubudu91
Copy link
Contributor

pubudu91 commented Jun 3, 2019

Shall we consider not inserting function params with default values when completing functions? It's annoying to have to keep deleting unwanted params.
@kaviththiranga kaviththiranga added Team/LanguageServer Language Server Implementation related issues. #Compiler and removed Component/VScodePlugin labels Jun 10, 2019
@nadeeshaan
Copy link
Contributor

@pubudu91 +1 for the suggestion. We'll include the changes and update the thread

nadeeshaan added a commit to nadeeshaan/ballerina that referenced this issue Jun 11, 2019
@nadeeshaan
Fix Issues ballerina-platform#15503 and ballerina-platform#14751
bd243bf
@nadeeshaan nadeeshaan mentioned this issue Jun 11, 2019
Merged
14 tasks
@kaviththiranga kaviththiranga mentioned this issue Jun 13, 2019
Closed
32 tasks
nadeeshaan added a commit that referenced this issue Jun 13, 2019
@nadeeshaan
Merge pull request #15651 from nadeeshaan/dev-branch
9396d82 
Fix Issues #15503, #14751 and #14346
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nadeeshaan nadeeshaan

Labels
Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Issues #15503, #14751 and #14346 nadeeshaan/ballerina
3 participants
@nadeeshaan @kaviththiranga @pubudu91