-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove redundant APIs and replace usages of Encoding module #18309
Remove redundant APIs and replace usages of Encoding module #18309
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18309 +/- ##
=======================================
Coverage 14.86% 14.86%
=======================================
Files 48 48
Lines 1265 1265
Branches 201 201
=======================================
Hits 188 188
Misses 1063 1063
Partials 14 14 Continue to review full report at Codecov.
|
…ina-lang into improve-encoding # Conflicts: # tests/jballerina-integration-test/src/test/resources/auth/src/authservices/oauth2-mock-server.bal
@@ -0,0 +1,63 @@ | |||
/* | |||
* Copyright (c) 2017, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Copyright (c) 2017, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. | |
* Copyright (c) 2019, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an old class [1]. I just moved it to the encoding module, renamed and updated.
…ina-lang into improve-encoding # Conflicts: # language-server/modules/langserver-core/src/test/resources/completion/function/delimiterBasedCompletionForCompleteSource1.json # language-server/modules/langserver-core/src/test/resources/completion/function/matchStatementSuggestions4.json # language-server/modules/langserver-core/src/test/resources/completion/function/workerDeclarationContext4.json # language-server/modules/langserver-core/src/test/resources/completion/packageimport/packageImport1.json # language-server/modules/langserver-core/src/test/resources/completion/toplevel/globalVarDefPackageContent.json # language-server/modules/langserver-core/src/test/resources/completion/toplevel/topLevelPackageContentAccess.json
Purpose
This PR removes the redundant APIs of
ballerina/encoding
module, with the newly introduced APIs oflanglib/array
andlanglib/string
.Newly introduced APIs in
langlib/array
moduleNewly introduced APIs in
langlib/string
moduleMatching APIs in the
ballerina/encoding
moduleAdditionally, the following URI encoding/decoding APIs which are in the
ballerina/http
module is moved to theballerina/encoding
module as follows:Existing APIs in the
ballerina/http
module:Proposed new APIs for the
ballerina/encoding
module:Related discussion: https://groups.google.com/d/msg/ballerina-dev/sbASEwIl44k/0YlP3IcXFwAJ
Fixes ballerina-platform/ballerina-spec#314
Check List