Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove unused encoding module dependencies #18619

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

ldclakmal
Copy link
Member

Purpose

The PR #18309 removes the redundant APIs of ballerina/encoding module, with the newly introduced APIs of langlib/array and langlib/string.

As of now, ballerina/encoding is used by only ballerina/jwt and ballerina/websub modules. This PR removes the unused dependencies of the ballerina/encoding module.

Check List

  • Read the Contributing Guide
  • Required Balo version update
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@ldclakmal ldclakmal added this to the Ballerina 1.0.0-rc1 milestone Sep 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #18619 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18619   +/-   ##
=======================================
  Coverage   15.15%   15.15%           
=======================================
  Files          48       48           
  Lines        1254     1254           
  Branches      197      197           
=======================================
  Hits          190      190           
  Misses       1050     1050           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b6f85...cee30e6. Read the comment docs.

@ldclakmal ldclakmal merged commit 77556f4 into ballerina-platform:master Sep 5, 2019
@keizer619 keizer619 modified the milestones: Ballerina 1.0.0-rc1, Ballerina 1.0.0 Oct 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Team/StandardLibs All Ballerina standard libraries Type/Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants