Prevent underscores from being removed in dim names #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dimension names of the groups specific effects end with
__expr_dim
and__factor_dim
.For example, if the term is
(categorical | group)
then the dimension names arecategorical__expr_dim
andgroup__factor_dim
.When using aliases, we were replacing the term name with the alias, but we were accidentally removing the
"__"
, so dimnames would turn out to bealiasfactor_dim
. This PR fixes that so the dimname isalias__factor_dim
.