Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent underscores from being removed in dim names #664

Merged
merged 3 commits into from
Apr 7, 2023

Conversation

tomicapretto
Copy link
Collaborator

The dimension names of the groups specific effects end with __expr_dim and __factor_dim.

For example, if the term is (categorical | group) then the dimension names are categorical__expr_dim and group__factor_dim.

When using aliases, we were replacing the term name with the alias, but we were accidentally removing the "__", so dimnames would turn out to be aliasfactor_dim. This PR fixes that so the dimname is alias__factor_dim.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #664 (3d1d85f) into main (341966f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files          40       40           
  Lines        2650     2650           
=======================================
  Hits         2322     2322           
  Misses        328      328           
Impacted Files Coverage Δ
bambi/backend/terms.py 96.44% <100.00%> (ø)
bambi/families/multivariate.py 98.33% <100.00%> (ø)
bambi/families/univariate.py 90.37% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto tomicapretto merged commit d9ca5d9 into bambinos:main Apr 7, 2023
@tomicapretto tomicapretto deleted the fix_dims branch April 7, 2023 01:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants