Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent underscores from being removed in dim names #664

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Prevent underscores from being removed in dim names #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a957c13
add underscores to dim names
tomicapretto Apr 6, 2023
47a486a
Fix dim names multinomial family
tomicapretto Apr 6, 2023
3d1d85f
Fix dimname categorical family
tomicapretto Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bambi/backend/terms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def get_coords(self):
new_coords = {}
for key, value in coords.items():
_, kind = key.split("__")
new_coords[self.term.alias + kind] = value
new_coords[self.term.alias + "__" + kind] = value
return new_coords

def build_distribution(self, prior, label, **kwargs):
Expand Down
2 changes: 1 addition & 1 deletion bambi/families/multivariate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def posterior_predictive(self, model, posterior, **kwargs):

def get_coords(self, response):
# For the moment, it always uses the first column as reference.
name = response.name + "_dim"
name = get_aliased_name(response) + "_dim"
labels = self.get_levels(response)
return {name: labels[1:]}

Expand Down
2 changes: 1 addition & 1 deletion bambi/families/univariate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def get_data(self, response):
return np.nonzero(response.term.data)[1]

def get_coords(self, response):
name = response.name + "_dim"
name = get_aliased_name(response) + "_dim"
return {name: [level for level in response.levels if level != response.reference]}

def get_reference(self, response):
Expand Down