Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: AWS support secret mutation #131

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Aug 2, 2024

Overview

  • This PR starts implementing AWS support for the Webhook.
  • Follow-up PR's to be expected.
  • I wanted to break down this implementation per mutated kind, so it is easier to review.

Part of #62

Notes for reviewers

@csatib02 csatib02 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 2, 2024
@csatib02 csatib02 self-assigned this Aug 2, 2024
@csatib02 csatib02 requested a review from a team as a code owner August 2, 2024 11:49
@csatib02 csatib02 changed the title Feat/aws support secrets feat: AWS support secrets Aug 2, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Aug 2, 2024
@csatib02 csatib02 removed the request for review from a team August 2, 2024 11:49
pkg/provider/aws/secret.go Fixed Show fixed Hide fixed
@csatib02 csatib02 force-pushed the feat/aws-support-secrets branch 3 times, most recently from 2c94a3f to 26b24e8 Compare August 7, 2024 07:31
ramizpolic
ramizpolic previously approved these changes Aug 8, 2024
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>

feat: aws support secrets

Signed-off-by: Bence Csati <bcsati@cisco.com>

feat: aws support secrets

Signed-off-by: Bence Csati <bcsati@cisco.com>

feat: aws support secrets

Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
@csatib02 csatib02 force-pushed the feat/aws-support-secrets branch from 905c0ed to 0685146 Compare August 8, 2024 09:07
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@csatib02 csatib02 merged commit e2516a0 into main Aug 8, 2024
26 checks passed
@csatib02 csatib02 deleted the feat/aws-support-secrets branch August 8, 2024 10:44
@csatib02 csatib02 changed the title feat: AWS support secrets feat: AWS support secret mutation Aug 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/provider/aws kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 500-999 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants