-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: AWS support secret mutation #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csatib02
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Aug 2, 2024
csatib02
force-pushed
the
feat/aws-support-secrets
branch
3 times, most recently
from
August 7, 2024 07:31
2c94a3f
to
26b24e8
Compare
ramizpolic
reviewed
Aug 7, 2024
ramizpolic
reviewed
Aug 8, 2024
ramizpolic
previously approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com> feat: aws support secrets Signed-off-by: Bence Csati <bcsati@cisco.com> feat: aws support secrets Signed-off-by: Bence Csati <bcsati@cisco.com> feat: aws support secrets Signed-off-by: Bence Csati <bcsati@cisco.com>
Signed-off-by: Bence Csati <bcsati@cisco.com>
csatib02
force-pushed
the
feat/aws-support-secrets
branch
from
August 8, 2024 09:07
905c0ed
to
0685146
Compare
akijakya
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
area/provider/aws
kind/feature
Categorizes issue or PR as related to a new feature.
size/L
Denotes a PR that changes 500-999 lines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Part of #62
Notes for reviewers