-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CALL JOB:SET_TCPON before TCPON command #18
Labels
rule
Adds a new YASKAWA rule
Comments
barisccolak
added a commit
that referenced
this issue
Oct 11, 2023
…rule class is defined, #17 documentation is started. Ruff check and black check completed.
Merged
barisccolak
added a commit
that referenced
this issue
Oct 20, 2023
barisccolak
added a commit
that referenced
this issue
Oct 25, 2023
* Rule class is created, third rule is developing. * #18 rule defined, #14 rule formatting completed, #20 rule defined, #22 rule class is defined, #17 documentation is started. Ruff check and black check completed. * #15 new rule implemented. * #19 implemented (CALL JOB:TRIGGER around ARCON/ARCOFF commands) * Script is modified to work on a multiple file (#24) and pre-commit created (#23) * Test folder with two JBI files is created. * Working on GitHub Actions. * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Update githubaction.yml * Set USERFRAME bug is corrected. * Extra test files are added. * check_E (#15) bug is corrected. * check_B (#11) bug is corrected. * check_D (#18) int bug argument is corrected. * Not UTF-8 encoded file handling is added. * Error Flag is implemented. * No Foldername is accepted. * Black applied. * Some reformating. * Some reformating. * Apply suggestions from code review Co-authored-by: Çağtay Fabry <cagtay.fabry@bam.de> * Files folder is deleted. * check_D bug solved. * check_D bug solved. * Review notes are implemented and updated. * Comments are corrected. Segmentation of the classes and error handling improved. --------- Co-authored-by: Çağtay Fabry <cagtay.fabry@bam.de>
Buggy behaviour:
Multiple TCPON's, code delivers no error. |
barisccolak
added a commit
that referenced
this issue
Nov 2, 2023
Merged
barisccolak
added a commit
that referenced
this issue
Nov 7, 2023
* Environment setup * test_checks is implemented (work in progress) * test_check_C_error_3 is implemented. * some tests and debugging implemented. * check_D bug is solved (#18) * Tests are implemented until check_E (#42) * Tests are implemented until check_E (#42) * add pytest action and update config (#44) * Testing With this commit: -Tests until check_H are implemented. -check_F can detect and return multiple errors --------- Co-authored-by: Çağtay Fabry <cagtay.fabry@bam.de>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
When a the
TCPON
command is called, the previous line must be a call toCALL JOB:SET_TCPON
with the same argument number in both cases.Example (OK):
Example (error, the
JOB:SET_TCPON
is called with input 33, theTCPON
command is called with argument 22. These numbers must match):Example (error, the line before
TCPON
is notCALL JOB:SET_TCPON
):The text was updated successfully, but these errors were encountered: