Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CALL JOB:SET_TCPON before TCPON command #18

Closed
CagtayFabry opened this issue Oct 9, 2023 · 1 comment · Fixed by #41
Closed

CALL JOB:SET_TCPON before TCPON command #18

CagtayFabry opened this issue Oct 9, 2023 · 1 comment · Fixed by #41
Assignees
Labels
rule Adds a new YASKAWA rule

Comments

@CagtayFabry
Copy link
Collaborator

CagtayFabry commented Oct 9, 2023

When a the TCPON command is called, the previous line must be a call to CALL JOB:SET_TCPON with the same argument number in both cases.

Example (OK):

CALL JOB:SET_TCPON ARGF1
TCPON TL#(1)

Example (error, the JOB:SET_TCPON is called with input 33, the TCPON command is called with argument 22. These numbers must match):

CALL JOB:SET_TCPON ARGF33
TCPON TL#(22)

Example (error, the line before TCPON is not CALL JOB:SET_TCPON):

TIMER T=0.50
TCPON TL#(1)
@CagtayFabry CagtayFabry added the rule Adds a new YASKAWA rule label Oct 9, 2023
barisccolak added a commit that referenced this issue Oct 11, 2023
…rule class is defined, #17 documentation is started. Ruff check and black check completed.
@barisccolak barisccolak mentioned this issue Oct 11, 2023
barisccolak added a commit that referenced this issue Oct 25, 2023
* Rule class is created, third rule is developing.

* #18 rule defined, #14 rule formatting completed, #20 rule defined, #22 rule class is defined, #17 documentation is started. Ruff check and black check completed.

* #15 new rule implemented.

* #19 implemented (CALL JOB:TRIGGER around ARCON/ARCOFF commands)

* Script is modified to work on a multiple file (#24) and pre-commit created (#23)

* Test folder with two JBI files is created.

* Working on GitHub Actions.

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Update githubaction.yml

* Set USERFRAME bug is corrected.

* Extra test files are added.

* check_E (#15) bug is corrected.

* check_B (#11) bug is corrected.

* check_D (#18) int bug argument is corrected.

* Not UTF-8 encoded file handling is added.

* Error Flag is implemented.

* No Foldername is accepted.

* Black applied.

* Some reformating.

* Some reformating.

* Apply suggestions from code review

Co-authored-by: Çağtay Fabry <cagtay.fabry@bam.de>

* Files folder is deleted.

* check_D bug solved.

* check_D bug solved.

* Review notes are implemented and updated.

* Comments are corrected. Segmentation of the classes and error handling improved.

---------

Co-authored-by: Çağtay Fabry <cagtay.fabry@bam.de>
@barisccolak barisccolak reopened this Oct 30, 2023
@barisccolak
Copy link
Owner

barisccolak commented Oct 30, 2023

Buggy behaviour:

CALL JOB:SET_TCPON ARGF1
TCPON TL#(1)
CALL JOB:SET_TCPON ARGF33
TCPON TL#(22)

Multiple TCPON's, code delivers no error.

barisccolak added a commit that referenced this issue Nov 2, 2023
@CagtayFabry CagtayFabry reopened this Nov 6, 2023
@CagtayFabry CagtayFabry linked a pull request Nov 6, 2023 that will close this issue
barisccolak added a commit that referenced this issue Nov 7, 2023
* Environment setup

* test_checks is implemented (work in progress)

* test_check_C_error_3 is implemented.

* some tests and debugging implemented.

* check_D bug is solved (#18)

* Tests are implemented until check_E (#42)

* Tests are implemented until check_E (#42)

* add pytest action and update config (#44)

* Testing

With this commit:
-Tests until check_H are implemented.
-check_F can detect and return multiple errors

---------

Co-authored-by: Çağtay Fabry <cagtay.fabry@bam.de>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rule Adds a new YASKAWA rule
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants