Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Unit Testing #41

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Unit Testing #41

merged 9 commits into from
Nov 7, 2023

Conversation

barisccolak
Copy link
Owner

@barisccolak barisccolak commented Oct 31, 2023 •
edited
Loading

This merge request contains:
-An update in GitHub workflows
-Added coverage reports dependency in pyproject.toml
-Debugging in fileparser.py
-Matchin Test files and test_checks for check_A to check_H functions

@barisccolak barisccolak changed the title Environment setup Unit Testing Nov 1, 2023
@barisccolak
Copy link
Owner Author

barisccolak commented Nov 3, 2023 •
edited
Loading

Relevant lines of not covered cases during testing: 316, 325 and 327 (except class JobFile)

@CagtayFabry CagtayFabry linked an issue Nov 6, 2023 that may be closed by this pull request
CALL JOB:SET_TCPON before TCPON command #18
Closed
CagtayFabry
CagtayFabry approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@CagtayFabry CagtayFabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Already at 54 tests 🚀

The descriptions of error codes W7 and W8 are missing from the README.md file.

@barisccolak barisccolak merged commit 4bfd087 into main Nov 7, 2023
@barisccolak barisccolak deleted the testing branch November 7, 2023 08:32
@CagtayFabry CagtayFabry mentioned this pull request Nov 21, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@CagtayFabry CagtayFabry CagtayFabry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CALL JOB:SET_TCPON before TCPON command
2 participants
@barisccolak @CagtayFabry