Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Respect configured filename for models file #1230

Closed
wants to merge 2 commits into from

Conversation

sebastiandedeyne
Copy link

@sebastiandedeyne sebastiandedeyne commented Jun 24, 2021

Summary

With this change, the filename configuration will also be used for the models file (suffixed by _models).

For example:

// config/ide-helpers.php

return [
    'filename' => 'my_ide_helper'
];

Will generate my_ide_helper.php and my_ide_helper_models.php.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@barryvdh
Copy link
Owner

barryvdh commented Aug 4, 2021

I don't know, would it make more sense to just add a second configuration option? Right now it would change the existing filenames if you have configured it, which we could see as breaking.

@wimski
Copy link
Contributor

wimski commented Aug 9, 2021

I don't know, would it make more sense to just add a second configuration option?

#1241

@mfn
Copy link
Collaborator

mfn commented Aug 9, 2021

Acks, seems if the other PR gets merged, we can close this one 🤷‍♀️

@mfn
Copy link
Collaborator

mfn commented Aug 10, 2021

Acks, seems if the other PR gets merged, we can close this one 🤷‍♀️

Closing, as #1241 has been merged!

@mfn mfn closed this Aug 10, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants