Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move default models filename to config #1241

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

wimski
Copy link
Contributor

@wimski wimski commented Aug 8, 2021

Summary

The models helper filename is the only filename that is hard-coded and not configurable. This PR makes the helper filename locations consistent.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Code style has been fixed via composer fix-style

@wimski wimski force-pushed the maintenance/models-file branch from 46fea3a to 53cc67c Compare August 8, 2021 14:03
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you validate my feedback?

@wimski wimski force-pushed the maintenance/models-file branch from 1ab446b to 36d395f Compare August 9, 2021 07:00
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mfn mfn requested a review from barryvdh August 9, 2021 20:29
@barryvdh barryvdh merged commit c733bde into barryvdh:master Aug 10, 2021
@wimski wimski deleted the maintenance/models-file branch August 12, 2021 06:57
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
* Move default models filename to config

* Add default value when getting models helper filename from config

* composer fix-style

Co-authored-by: laravel-ide-helper <laravel-ide-helper@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants