Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upstream Bzlmod changes to original repositories #124

Closed
7 of 18 tasks
meteorcloudy opened this issue Jul 5, 2022 · 9 comments
Closed
7 of 18 tasks

Upstream Bzlmod changes to original repositories #124

meteorcloudy opened this issue Jul 5, 2022 · 9 comments
Labels
bounty-1000USD Bug Bounty: A contributor who completes this can be paid by the Rules Authors SIG good first issue Good for newcomers help wanted Extra attention is needed

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented Jul 5, 2022

As part of #7, there were many Bazel modules checked in the BCR with custom MODULE.bazel files and patches while the original project doesn't natively support Bzlmod. To drive the Bzlmod migration in the community, we need help to upstream the MODULE.bazel files and patches back to the original repositories.

The list of modules in the BCR that already natively supports Bazel but not yet migrated to Bzlmod are:

  • bazel_skylib
  • protobuf
  • platforms
  • rules_proto
  • rules_pkg
  • rules_python
  • rules_nodejs
  • rules_license
  • grpc
  • glog
  • googletest
  • gflags
  • upb
  • c-ares
  • abseil-cpp
  • re2
  • boringssl
  • stardoc

Note that the MODULE.bazel files and patches in the BCR for them only ensure the minimal use case can work, to fully migrate those projects to Bzlmod probably requires extra work.

@meteorcloudy meteorcloudy added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 5, 2022
@alexeagle
Copy link
Contributor

For anyone who'd be motivated by a payout for helping here, there's money in the https://opencollective.com/bazel-rules-authors-sig which we can turn into a bug bounty here.

@alexeagle
Copy link
Contributor

Here's a start for rules_python bazelbuild/rules_python#744

@alexeagle
Copy link
Contributor

FYI I checked off rules_nodejs - I don't think it belonged on that list though, since no file for it was ever committed as part of #7. (same for rules_sass - I assume those are only needed for building some documentation site and not for the bazel binary, so they were omitted from #7 as not strictly needed for building Bazel)

@meteorcloudy
Copy link
Member Author

@alexeagle Regardless of #7, rules_nodejs still fits the definition of "The list of modules in the BCR that already natively supports Bazel but not yet migrated to Bzlmod", right?
Don't you think rules_nodejs should also support Bzlmod natively giving "aspect_rules_js" still depends on it?

@alexeagle
Copy link
Contributor

Sure, I was a bit too pedantic there - rules_nodejs is migrated to bzlmod already.

@alexeagle alexeagle added the bounty-1000USD Bug Bounty: A contributor who completes this can be paid by the Rules Authors SIG label Jul 12, 2022
tetromino added a commit to bazelbuild/bazel-skylib that referenced this issue Aug 30, 2022
Creates MODULE.bazel and WORKSPACE.bzlmod files to enable bazel-skylib
to work with the `--experimental_enable_bzlmod` flag.

rules_go has been updated as the previously used version is not
available in the BCR.

stardoc has been updated due to a strange issue with Bzlmod enabled that
caused the `diff_test` and `unittest` docs to be generated without any
contents that was magically fixed upon updating.

bazelbuild/bazel-central-registry#124

Co-authored-by: Alexandre Rostovtsev <arostovtsev@google.com>
@Vertexwahn
Copy link
Contributor

FYI: Abseil and Google Test have now a MODULE.bazel file.

PR for gflags is open since Sep 16, 2023: gflags/gflags#353

@mering
Copy link
Contributor

mering commented Feb 12, 2024

Should we link upstream tracking issues and PRs here as well?

protobuf: protocolbuffers/protobuf#13618
grpc: grpc/grpc#35271

@mering
Copy link
Contributor

mering commented Feb 12, 2024

Furthermore, upb is deprecated: https://github.com/protocolbuffers/upb#readme

@Wyverald
Copy link
Member

This issue is largely outdated -- most (if not all) of the mentioned repos now have first-class Bzlmod support. (Except c-ares, which doesn't have any Bazel files at all.)

ngiloq6 added a commit to ngiloq6/bazel-skylib that referenced this issue Aug 17, 2024
Creates MODULE.bazel and WORKSPACE.bzlmod files to enable bazel-skylib
to work with the `--experimental_enable_bzlmod` flag.

rules_go has been updated as the previously used version is not
available in the BCR.

stardoc has been updated due to a strange issue with Bzlmod enabled that
caused the `diff_test` and `unittest` docs to be generated without any
contents that was magically fixed upon updating.

bazelbuild/bazel-central-registry#124

Co-authored-by: Alexandre Rostovtsev <arostovtsev@google.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bounty-1000USD Bug Bounty: A contributor who completes this can be paid by the Rules Authors SIG good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants