Support Bzlmod #607
Closed
Support Bzlmod #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiuto
requested changes
Aug 19, 2022
|
@aiuto Thanks for the review. Sure. I'll update this PR to add only two files. |
|
It seems like CI is failing with the almost same error message as #485. |
|
Closing as commented above. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a support Bzlmod to upstream MODULE.bazel file to this repo as per bazelbuild/bazel-central-registry#124. It seems there is an existing similar PR #485, but it seems there is no update since February. I'm totally fine to abandon this PR if #485 is better as long as rules_pkg supports Bzlmod.