Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[8.1.0] Add repository_ctx.original_name #25191

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 4, 2025

This new attribute contains the original value of the name attribute at the instantiation site of the repo rule (e.g., rctx.original_name would be foo if rctx.name is +ext+foo).

Fixes #24467

Closes #25121.

RELNOTES: Added repository_ctx.original_name, which contains the original value of the name attribute as specified at the repo rule call site.

PiperOrigin-RevId: 722731393
Change-Id: I2f7dada0c44b6bd4c0d2622fa1e97223382a8547
(cherry picked from commit 8bcfb06)

Fixes #25147

@fmeum fmeum requested a review from a team as a code owner February 4, 2025 16:09
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Feb 4, 2025
This new attribute contains the original value of the `name` attribute at the instantiation site of the repo rule (e.g., `rctx.original_name` would be `foo` if `rctx.name` is `+ext+foo`).

Fixes bazelbuild#24467

Closes bazelbuild#25121.

RELNOTES: Added `repository_ctx.original_name`, which contains the original value of the `name` attribute as specified at the repo rule call site.
PiperOrigin-RevId: 722731393
Change-Id: I2f7dada0c44b6bd4c0d2622fa1e97223382a8547
(cherry picked from commit 8bcfb06)
@iancha1992 iancha1992 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into bazelbuild:release-8.1.0 with commit b016ff3 Feb 5, 2025
45 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Feb 5, 2025
@fmeum fmeum deleted the release-8.1.0 branch February 5, 2025 14:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants