Resolve - run rubocop on each commit on travis #15 #16
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add travis and rubocop * Source rubocop config from remote repo @see https://travis-ci.org/ajohnstone/cloudwatch-sender/
|
Sweet 👍 |
|
🍰 |
|
Any chance of merging this? I realise there are issues with the validation from rubocop, however that should be resolved separately to this. |
|
I tried to get our Travis working but had some auth issues due to Github Organisation - will try again. |
|
@revett Thanks 👍 |
|
This is 2 months old now? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Have to ask people to run rubocop which requires them to set it up and may conflict with rubocop setups they already have. I.e: #11
Solution
Run rubocop on each commit in travis then mark the PR as pass/failure based on the result from rubocop.
15 files inspected, 28 offenses detected)@see https://travis-ci.org/ajohnstone/cloudwatch-sender/