Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

estimatesmartfee RPC API result inconsistent with Bitcoin Core RPC API (fee vs feerate) #1153

Closed
nkuba opened this issue May 24, 2023 · 1 comment

Comments

@nkuba
Copy link

nkuba commented May 24, 2023

Bitcoin Core RPC API defines the result of estimatesmartfee method to return a feerate property (see: https://developer.bitcoin.org/reference/rpc/estimatesmartfee.html#result).

While Bcoin RPC API returns a fee property instead:

bcoin/lib/node/rpc.js

Lines 2233 to 2236 in 92433b2

return {
fee: fee,
blocks: blocks
};

The fee property should be renamed to feerate to maintain compatibility across the clients.

pdyraga added a commit to keep-network/keep-core that referenced this issue Jun 15, 2023
This PR adds Kubernetes manifests of bitcoin node and electrumx server.

The configuration is based on the V1's config:
https://github.com/keep-network/tbtc/tree/main/infrastructure/kube/keep-test
with some improvements.

For V1 we were running bcoin, now we switch to bitcoind, due to
bcoin-org/bcoin#1153

Bitcoind and Electrum servers are running in dedicated kubernetes
namespaces:
- for keep-test: `bitcoin-testnet`
- for keep-prd: `bitcoin`

We started with one replica for each server and after sync was done, we
created snapshots that were used for PVC creation for other replicas.

Closes: #3590
@theanmolsharma
Copy link
Collaborator

Fixed in 014a104

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants