feat: align 'estimatesmartfee' rpc with bitcoind

[emjshrx]

Changes the returned json attribute from 'estimatesmartfee' rpc to align with bitcoind docs . Also added a crude test to verify the same.

Fixes #1153

[theanmolsharma]

Thanks, good call. I'll review it this week.
While I do that if you can, please scrutinize the other RPCs as well. I know this is a tedious and boring task so no pressure.

[emjshrx]

Thanks, good call. I'll review it this week. While I do that if you can, please scrutinize the other RPCs as well. I know this is a tedious and boring task so no pressure.

Thanks @theanmolsharma . Also I noticed the coverage in RPCs are quite less so can make a test suite for them as well.

[emjshrx]

Changed the test to be in the right file and ran a formatter on the file

[theanmolsharma]

Changed the test to be in the right file and ran a formatter on the file

Please revert back the formatter changes.

[theanmolsharma]

Tested ACK

[pinheadmz]

since this is a breaking change, we must also include a release note in the CHANGELOG.md anyone who is using this API regularly for their application will get wrecked if they upgrade and don't comply.

[emjshrx]

since this is a breaking change, we must also include a release note in the CHANGELOG.md anyone who is using this API regularly for their application will get wrecked if they upgrade and don't comply.

Thanks for bringing this to notice @pinheadmz . Have made the changes.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (b005869) 69.55% compared to head (350e6b0) 69.57%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
+ Coverage   69.55%   69.57%   +0.01%     
==========================================
  Files         158      159       +1     
  Lines       26603    26607       +4     
==========================================
+ Hits        18505    18511       +6     
+ Misses       8098     8096       -2     

Impacted Files	Coverage Δ
lib/node/rpc.js	41.96% <ø> (+0.57%)	⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pinheadmz]

If you're going to touch this line, it should be like this:

      // Get current chain tip and chain height
      const chainHeight = node.chain.tip.height + 1;
      const chainTip = util.revHex(node.chain.tip.hash);

[emjshrx]

Fixed this annoying formatting change. I did not intend to touch these lines.

[pinheadmz]

merged 014a104
thank you!