Ensure assorted non-engine crates are formatted in CI

[alice-i-cecile]

          Yep. This is what we have to do, otherwise someone else is gonna run into this eventually.

Additionally, from the Bevy side, this should be checked by CI.

Originally posted by @rlidwka in #10758 (review)

[matiqo15]

The issue here lies in that benches are not checked by cargo fmt --all -- --check. I've found two ways to solve it:

1. We can add "benches" to members of workspace in Cargo.toml. However, this could add additional overhead - especially as "benches" are currently explicitly excluded from members.
2. We could add flag in tools/ci/src/main.rs. This would then be: cmd!(sh, "cargo fmt --all --manifest-path ../../../benches/Cargo.toml -- --check"). While not best, it seems to be the only solution I've found if we don't want to add benches to workspace.

[alice-i-cecile]

I think we should start with solution 2 for now.

[mockersf]

As you said, the issue is that benches (and compile fail crates) are excluded from the workspace:

bevy/Cargo.toml

Lines 15 to 21 in 4221f7e

	[workspace]
	exclude = [
	"benches",
	"crates/bevy_ecs_compile_fail_tests",
	"crates/bevy_macros_compile_fail_tests",
	"crates/bevy_reflect_compile_fail_tests",
	]

I don't remember why, but if we want the benches to be checked in CI (format, clippy, ...) they should be in the workspace.

[BD103]

I fixed part of this issue in #16858 when I added benchmarks and compile_fail tests to the workspace. In #17330, however, new integration tests were added that are excluded from the workspace. @raldone01 is there a particular reason why you chose to exclude them?

[raldone01]

The reason the integration tests were excluded from the workspace was because their whole purpose is to be standalone crates that depend on bevy.

I think there was an issue with them also being part of the bevy workspace.

I did not want to add more complexity/magic to the integration tests by copy Cargo tomls and so on. The integration tests work like regular crates when you cd into them.

[BD103]

Makes sense! I suppose being part of the workspace could affect their dependency resolution / inappropriately reuse build artifacts. Since it seems ideal to keep integration tests separate from the main workspace, I'll just modify the issue title to mention them.

Edit: Turns out I cannot edit titles. To anyone in the future planning on tackling this, your goal is to ensure the integration tests are checked with rustfmt in CI without adding them to the workspace. Benchmarks and tool crates are already in the workspace at this point, so don't worry about them! :)