Skip to content

Main branch fails to compile on Rust beta. #18748

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
github-actions bot opened this issue Apr 7, 2025 · 10 comments
Closed

Main branch fails to compile on Rust beta. #18748

github-actions bot opened this issue Apr 7, 2025 · 10 comments
Labels
A-Pointers Relating to Bevy pointer abstractions C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Weekly CI run has failed.

The offending run.
@github-actions github-actions bot added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Apr 7, 2025
@MatrixFrog
Copy link 

error: use `core::ptr::eq` when comparing raw pointers
   --> crates/bevy_ecs/src/intern.rs:110:9
    |
110 |         self.as_ptr() == other.as_ptr() && self.len() == other.len()
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::ptr::eq(self.as_ptr(), other.as_ptr())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
    = note: `-D clippy::ptr-eq` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::ptr_eq)]`

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! A-Pointers Relating to Bevy pointer abstractions and removed C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Apr 9, 2025
@hukasu
Copy link
Contributor

hukasu commented Apr 10, 2025

this was a contentious change on cargo clippy and there is discussion about which cases should continue and which should be reverted

rust-lang/rust-clippy#14525
rust-lang/rust-clippy#14526

@github-actions GitHub Actions
Copy link
Contributor Author

Weekly pipeline still fails: https://github.com/bevyengine/bevy/actions/runs/14445077085

@github-actions GitHub Actions
Copy link
Contributor Author

Weekly pipeline still fails: https://github.com/bevyengine/bevy/actions/runs/14573092616

@github-actions GitHub Actions
Copy link
Contributor Author

Weekly pipeline still fails: https://github.com/bevyengine/bevy/actions/runs/14707273889

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 5, 2025

Weekly pipeline still fails: https://github.com/bevyengine/bevy/actions/runs/14835919843

@github-actions GitHub Actions
Copy link
Contributor Author

Weekly pipeline still fails: https://github.com/bevyengine/bevy/actions/runs/14971654930

@github-actions GitHub Actions
Copy link
Contributor Author

Weekly pipeline still fails: https://github.com/bevyengine/bevy/actions/runs/15112410443

@hukasu hukasu mentioned this issue May 19, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue May 20, 2025
@hukasu
Fix warnings and errors reported on Rust beta (#19294)
55edb0b 
# Objective

Fixes errors and warnings on this week's Rust beta pipeline 
*
#18748 (comment)
@mockersf
Copy link
Member

closed in #19294

@hukasu
Copy link
Contributor

hukasu commented May 20, 2025

was the beta pipeline re-run to make sure that there were no other errors?

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-Pointers Relating to Bevy pointer abstractions C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MatrixFrog @alice-i-cecile @hukasu @mockersf