Use default storage for TemporaryRenderEntity
#16462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
D-Trivial
alice-i-cecile
approved these changes
Nov 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
rparrett
force-pushed
the
temporary-re-dense
branch
from
92470fb to
7bc1b8f
Compare
BenjaminBrienen
approved these changes
Nov 22, 2024
|
Is there a justification from the original author of this line? I don't have the tools to see which PR added it at this moment. |
mockersf
pushed a commit
that referenced
this pull request
Nov 22, 2024
# Objective `TemporaryRenderEntity` currently uses `SparseSet` storage, but doesn't seem to fit the criteria for a component that would benefit from this. Typical usage of `TemporaryRenderEntity` (and all current usages of it in engine as far as I can tell) would be to spawn an entity with it once and then iterate over it once to despawn that entity. `SparseSet` is said to be useful for insert/removal perf at the cost of iteration perf. ## Solution Use the default table storage ## Testing Possibly this could show up in stress tests like `many_buttons`. I didn't do any benchmarking.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
# Objective `TemporaryRenderEntity` currently uses `SparseSet` storage, but doesn't seem to fit the criteria for a component that would benefit from this. Typical usage of `TemporaryRenderEntity` (and all current usages of it in engine as far as I can tell) would be to spawn an entity with it once and then iterate over it once to despawn that entity. `SparseSet` is said to be useful for insert/removal perf at the cost of iteration perf. ## Solution Use the default table storage ## Testing Possibly this could show up in stress tests like `many_buttons`. I didn't do any benchmarking.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective `TemporaryRenderEntity` currently uses `SparseSet` storage, but doesn't seem to fit the criteria for a component that would benefit from this. Typical usage of `TemporaryRenderEntity` (and all current usages of it in engine as far as I can tell) would be to spawn an entity with it once and then iterate over it once to despawn that entity. `SparseSet` is said to be useful for insert/removal perf at the cost of iteration perf. ## Solution Use the default table storage ## Testing Possibly this could show up in stress tests like `many_buttons`. I didn't do any benchmarking.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TemporaryRenderEntitycurrently usesSparseSetstorage, but doesn't seem to fit the criteria for a component that would benefit from this.Typical usage of
TemporaryRenderEntity(and all current usages of it in engine as far as I can tell) would be to spawn an entity with it once and then iterate over it once to despawn that entity.SparseSetis said to be useful for insert/removal perf at the cost of iteration perf.Solution
Use the default table storage
Testing
Possibly this could show up in stress tests like
many_buttons. I didn't do any benchmarking.