-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix scale_factor_override with cursor position. #2639
Conversation
Sometimes the wrong scale factor was used (not accounting for overrides). Fixes #2501
Nice catch! This implementation works, but to enable more flexibility and increased consistency, I think we should probably adopt our Window type's approach to width / physical_width here:
Then when handling the winit events, all we need to do is:
|
Why this PR was closed? 🤔 I think it works fine for me. |
Note: cart said that it works above. I closed it because I don't plan on addressing the comments, as is my prerogative. This PR could've had two responses:
Whether you think my characterization is fair or not, in specifics, the first one above clearly has no downside while showing new contributors that their time is valuable and the project avoids scope creep, at least for simple things. I don't plan on contributing to projects that don't value my time. |
# Objective - Fixes #2501 - Builds up on #2639 taking #2639 (comment) into account ## Solution - keep the physical cursor position in `Window`, and expose it. - still convert to logical position in event, and when getting `cursor_position` Co-authored-by: Ahmed Charles <acharles@outlook.com>
# Objective - Fixes bevyengine#2501 - Builds up on bevyengine#2639 taking bevyengine#2639 (comment) into account ## Solution - keep the physical cursor position in `Window`, and expose it. - still convert to logical position in event, and when getting `cursor_position` Co-authored-by: Ahmed Charles <acharles@outlook.com>
# Objective - Fixes bevyengine#2501 - Builds up on bevyengine#2639 taking bevyengine#2639 (comment) into account ## Solution - keep the physical cursor position in `Window`, and expose it. - still convert to logical position in event, and when getting `cursor_position` Co-authored-by: Ahmed Charles <acharles@outlook.com>
# Objective - Fixes #2501 - Builds up on #2639 taking bevyengine/bevy#2639 (comment) into account ## Solution - keep the physical cursor position in `Window`, and expose it. - still convert to logical position in event, and when getting `cursor_position` Co-authored-by: Ahmed Charles <acharles@outlook.com>
Sometimes the wrong scale factor was used (not accounting for
overrides).
Fixes #2501