[Merged by Bors] - Miri can set thread names now #5108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
mockersf
approved these changes
Jun 26, 2022
mockersf
added
the
S-Ready-For-Final-Review
DJMcNab
reviewed
Jun 26, 2022
crates/bevy_tasks/src/task_pool.rs
Outdated
| @@ -102,9 +102,6 @@ impl TaskPool { | |||
| let ex = Arc::clone(&executor); | |||
| let shutdown_rx = shutdown_rx.clone(); | |||
|
|
|||
| // miri does not support setting thread names | |||
| // TODO: change back when https://github.com/rust-lang/miri/issues/1717 is fixed | |||
| #[cfg(not(miri))] | |||
| let mut thread_builder = { | |||
There was a problem hiding this comment.
I don't think we'd have used a block expression here if it weren't for the cfg
DJMcNab
approved these changes
Jun 26, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2022
# Objective rust-lang/miri#1717 has been fixed so we can set thread names in Miri now. ## Solution We set thread names in Miri.
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective rust-lang/miri#1717 has been fixed so we can set thread names in Miri now. ## Solution We set thread names in Miri.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective rust-lang/miri#1717 has been fixed so we can set thread names in Miri now. ## Solution We set thread names in Miri.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective rust-lang/miri#1717 has been fixed so we can set thread names in Miri now. ## Solution We set thread names in Miri.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
rust-lang/miri#1717 has been fixed so we can set thread names in Miri now.
Solution
We set thread names in Miri.