Skip to content

[Merged by Bors] - flaky test: put panicking system in a single threaded stage #6172

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - flaky test: put panicking system in a single threaded stage #6172

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Oct 5, 2022

Objective

Solution

  • Put the panicking system in a single threaded stage during the test
  • This way only the main thread will panic, which is handled by cargo test

@cart
Copy link
Member

cart commented Oct 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 5, 2022
@mockersf
flaky test: put panicking system in a single threaded stage (#6172)
720b673 
# Objective

- Fix #5285 

## Solution

- Put the panicking system in a single threaded stage during the test
- This way only the main thread will panic, which is handled by `cargo test`
@bors
Copy link
Contributor

bors bot commented Oct 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title flaky test: put panicking system in a single threaded stage [Merged by Bors] - flaky test: put panicking system in a single threaded stage Oct 5, 2022
@bors bors bot closed this Oct 5, 2022
@mockersf mockersf added A-Transform Translations, rotations and scales hacktoberfest-accepted labels Oct 5, 2022
xgbwei pushed a commit to xgbwei/bevy that referenced this pull request Oct 5, 2022
@mockersf @xgbwei
flaky test: put panicking system in a single threaded stage (bevyengi…
6920176 
…ne#6172)

# Objective

- Fix bevyengine#5285 

## Solution

- Put the panicking system in a single threaded stage during the test
- This way only the main thread will panic, which is handled by `cargo test`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@mockersf @james7132
flaky test: put panicking system in a single threaded stage (bevyengi…
6b7a592 
…ne#6172)

# Objective

- Fix bevyengine#5285 

## Solution

- Put the panicking system in a single threaded stage during the test
- This way only the main thread will panic, which is handled by `cargo test`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
flaky test: put panicking system in a single threaded stage (bevyengi…
a7e6adb 
…ne#6172)

# Objective

- Fix bevyengine#5285 

## Solution

- Put the panicking system in a single threaded stage during the test
- This way only the main thread will panic, which is handled by `cargo test`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
flaky test: put panicking system in a single threaded stage (bevyengi…
d00f790 
…ne#6172)

# Objective

- Fix bevyengine#5285 

## Solution

- Put the panicking system in a single threaded stage during the test
- This way only the main thread will panic, which is handled by `cargo test`
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hymm hymm hymm approved these changes

Assignees
No one assigned
Labels
A-Transform Translations, rotations and scales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The test correct_transforms_when_no_children spuriously fails.
3 participants
@mockersf @cart @hymm