Skip to content

[Merged by Bors] - ignore nanosec precision tests on apple m1 #6377

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - ignore nanosec precision tests on apple m1 #6377

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

  • Some tests are very flaky on a m1
  • m1 currently have a 41 ns precision

Solution

  • Do not run tests that compare a Duration or a f64 on a m1 (and m2)

@hymm
Copy link
Contributor

hymm commented Oct 26, 2022

might be worth adding a comment that if rust-lang/rust#94100 gets merged that we can reenable the tests.

@mockersf
Copy link
Member Author

I linked to rust-lang/rust#91417

alice-i-cecile
alice-i-cecile approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration O-MacOS Specific to the MacOS (Apple) desktop operating system C-Testing A change that impacts how we test Bevy or how users test their apps labels Oct 26, 2022
bors bot pushed a commit that referenced this pull request Oct 26, 2022
@mockersf
ignore nanosec precision tests on apple m1 (#6377)
a083882 
# Objective

- Some tests are very flaky on a m1
- m1 currently have a 41 ns precision

## Solution

- Do not run tests that compare a `Duration` or a `f64` on a m1 (and m2)
@bors
Copy link
Contributor

bors bot commented Oct 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title ignore nanosec precision tests on apple m1 [Merged by Bors] - ignore nanosec precision tests on apple m1 Oct 26, 2022
@bors bors bot closed this Oct 26, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
ignore nanosec precision tests on apple m1 (bevyengine#6377)
6ada73b 
# Objective

- Some tests are very flaky on a m1
- m1 currently have a 41 ns precision

## Solution

- Do not run tests that compare a `Duration` or a `f64` on a m1 (and m2)
@maniwani maniwani mentioned this pull request Nov 18, 2022
Closed
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
ignore nanosec precision tests on apple m1 (bevyengine#6377)
3296ec6 
# Objective

- Some tests are very flaky on a m1
- m1 currently have a 41 ns precision

## Solution

- Do not run tests that compare a `Duration` or a `f64` on a m1 (and m2)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hymm hymm hymm approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Testing A change that impacts how we test Bevy or how users test their apps O-MacOS Specific to the MacOS (Apple) desktop operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @hymm @alice-i-cecile