disabling the managedkafka finalizer #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
operator
rareddy
approved these changes
Sep 27, 2021
ppatierno
approved these changes
Sep 27, 2021
k-wall
approved these changes
Sep 28, 2021
MikeEdgar
added a commit
that referenced
this pull request
Oct 1, 2021
MikeEdgar
added a commit
that referenced
this pull request
Oct 1, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another operator sdk upgrade followup. we logged an issue a while ago for the sdk to support not adding a finalizer. Since there is no action that we need to take at deletion time, we don't need the finalizer. This makes it easy to clean up managekafka resources without the operator running.