Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

disabling the managedkafka finalizer #516

Merged
merged 1 commit into from
Sep 28, 2021
Merged

disabling the managedkafka finalizer #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion operator/src/main/java/org/bf2/operator/controllers/ManagedKafkaAgentController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
* An alternative to this approach would be to have the ManagedKafkaControl make status
* updates directly based upon the changes it sees in the ManagedKafka instances.
*/
@Controller
@Controller(finalizerName = Controller.NO_FINALIZER)
public class ManagedKafkaAgentController implements ResourceController<ManagedKafkaAgent> {

@Inject
Expand Down
2 changes: 1 addition & 1 deletion operator/src/main/java/org/bf2/operator/controllers/ManagedKafkaController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
import java.util.Objects;
import java.util.Optional;

@Controller
@Controller(finalizerName = Controller.NO_FINALIZER)
public class ManagedKafkaController implements ResourceController<ManagedKafka> {

@Inject
Expand Down
3 changes: 3 additions & 0 deletions systemtest/src/test/java/org/bf2/systemtest/integration/SmokeST.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import java.util.concurrent.CompletableFuture;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

@Tag(TestTags.SMOKE)
public class SmokeST extends AbstractST {
Expand Down Expand Up @@ -99,6 +100,8 @@ void testCreateManagedKafka(ExtensionContext extensionContext) throws Exception
.readValue(SyncApiClient.getManagedKafkaStatus(mk.getId(), syncEndpoint).body(), ManagedKafkaStatus.class);
ManagedKafka managedKafka = ManagedKafkaResourceType.getOperation().inNamespace(mkAppName).withName(mkAppName).get();

assertTrue(managedKafka.getMetadata().getFinalizers() == null || managedKafka.getMetadata().getFinalizers().isEmpty());

AssertUtils.assertManagedKafkaStatus(managedKafka, apiStatus);

//Get agent status
Expand Down