Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

generated tests are incomplete #6

Open
7 tasks
sakulstra opened this issue Oct 26, 2023 · 0 comments
Open
7 tasks

generated tests are incomplete #6

sakulstra opened this issue Oct 26, 2023 · 0 comments
Labels
generator

Comments

@sakulstra
Copy link
Contributor

in theory each feature can define generated tests, but most features only generate the default test yet
Probably makes sense to improve so reviews are easier/less repetitive.

Features not yet covered with custom tests:
Preview Give feedback
brotherlymite pushed a commit that referenced this issue Dec 7, 2023
@miguelmtzinf @parth-15
Add proposal for Gho Incident Report 20231113 (#109)
157a3fc 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
eboadom pushed a commit that referenced this issue Jan 20, 2024
@The-3D @parth-15
@miguelmtzinf @foodaka
StkGHO Initialization proposal (#170)
1982811 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: added stkgho initialization proposal

* feat: fixed proposal description

* feat: removed submodule

* feat: fixed deployment script

* feat: replaced duration calculation

* git commit remove submodule

* feat: fixed payload build function

* update proposal

* sync branch

* fix: variable name

* fix: Fix AIP payload

* fix: Fix tests

* test: added further test on emission per day

* refactor: removed unused constants

* fix: catapulta commands

* fix: Add fixes to payload

* fix: Rebuild proposal with autogenerate tool

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: Mark Hinschberger <foodaka@users.noreply.github.com>
eboadom pushed a commit that referenced this issue Jan 24, 2024
@miguelmtzinf @parth-15 @brotherlymite
GHO Stability Module Launch (#169)
0f4c6e7 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add payload

* test: Add tests

* feat: Add script and tests with final addresses

* fix: Fix link and gasLimit amounts

* fix: Update dependencies

* fix: Fix oracle swap freezer addresses

* fix: Bump block number for tests

* fix: Reduce LINK amount so its enough in treasury

* add test for OracleSwapFreezer

* fix: Clean up in tests

* docs: Add AIP text

* docs: Fix typo in natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo on natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* docs: Fix typo in natspec docs

* fix: Add DAO as swap freezer

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
Rozengarden referenced this issue in AaveChan/aave-proposals-v3 Jan 30, 2024
@The-3D @parth-15
@miguelmtzinf @foodaka @Rozengarden
StkGHO Initialization proposal (bgd-labs#170)
4502099 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (bgd-labs#9)

* fix: Remove unneeded diff file (bgd-labs#10)

* feat: added stkgho initialization proposal

* feat: fixed proposal description

* feat: removed submodule

* feat: fixed deployment script

* feat: replaced duration calculation

* git commit remove submodule

* feat: fixed payload build function

* update proposal

* sync branch

* fix: variable name

* fix: Fix AIP payload

* fix: Fix tests

* test: added further test on emission per day

* refactor: removed unused constants

* fix: catapulta commands

* fix: Add fixes to payload

* fix: Rebuild proposal with autogenerate tool

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: Mark Hinschberger <foodaka@users.noreply.github.com>
Rozengarden referenced this issue in AaveChan/aave-proposals-v3 Jan 30, 2024
@miguelmtzinf @parth-15
@brotherlymite @Rozengarden
GHO Stability Module Launch (bgd-labs#169)
6d5b5de 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (bgd-labs#9)

* fix: Remove unneeded diff file (bgd-labs#10)

* feat: Add payload

* test: Add tests

* feat: Add script and tests with final addresses

* fix: Fix link and gasLimit amounts

* fix: Update dependencies

* fix: Fix oracle swap freezer addresses

* fix: Bump block number for tests

* fix: Reduce LINK amount so its enough in treasury

* add test for OracleSwapFreezer

* fix: Clean up in tests

* docs: Add AIP text

* docs: Fix typo in natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo on natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* docs: Fix typo in natspec docs

* fix: Add DAO as swap freezer

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
brotherlymite pushed a commit that referenced this issue Jun 14, 2024
@miguelmtzinf @parth-15
Add AIP for GHO Cross-Chain Launch (#350)
7725647 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add AIP code

* fix: Fix AIP docs and imports

* fix: Remove unnecesary test

* fix: Updates risk params

* test: Add ccip e2e tests

* fix: Fix Arbitrum payload max bytecode size exceeded

* feat: Add sophisticated defensive aave seed (#13)

* feat: Add sophhisticated defensive aave seed

* fix: Allows AaveDefensive contract remove itself as facilitator

* fix: Add docs and reduce bytecode size

* fix: Reduce Utils lib bytecode size

* fix: Fix error in Utils

* fix: Add Capped gho usd price oracle

* fix: Add AIP draft text

* fix: Update block number for tests

* fix: Remove unneeded files

* fix: Install latest version of gho and ccip repos

* fix: Remove unused helper function

* fix: Fix AIP text

* fix: Remove defensive and use create2

* fix: Add fixed price oracle

* fix: Remove unnecessary memory variables

* fix: Use create1 and move listing out

* fix: Remove listing aip

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
brotherlymite pushed a commit that referenced this issue Jun 17, 2024
@miguelmtzinf @parth-15
Fix GHO cross-chain AIP text (#360)
e0d12ee 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* fix: Fix AIP text

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
brotherlymite added a commit that referenced this issue Jun 26, 2024
@miguelmtzinf @parth-15 @brotherlymite
Add second AIP for GHO Cross-Chain Launch (#356)
c7161d8 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add proposal to onboard GHO

* fix: Fix AIP name

* fix: Update GHO ir

* fix: Fix diff report

* fix: Fix typo in AIP text

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo in AIP text

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix tests

* fix: Fix lint

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
sendra added a commit that referenced this issue Jul 29, 2024
@CheyenneAtapour @parth-15
@miguelmtzinf @sendra
AIP: Events and Sponsorships Grant 2024 (#384)
ba24358 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* initial upload: proposal template and fund stream

* test: add stream withdraw test

* docs: add summary and specs of AIP

* test: add fuzz and insufficient funds tests

* test: fuzz by seconds instead of days

* fix: test changes as per pr comments

* fix: comment typo

* fix: discussion links, deal funds directly in tests

* feat: update proposal doc

* fix: doc header and formatting

* fix: replace arfc with aip

* fix: Fix typo in AIP text

Co-authored-by: sendra <sendra@users.noreply.github.com>

* feat: initial upload of template

* feat: initial upload doc

* fix: aip not arfc

* fix: Updates lib

* fix: Fix AIP text

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: sendra <sendra@users.noreply.github.com>
brotherlymite added a commit that referenced this issue Nov 7, 2024
@miguelmtzinf @parth-15
@DhairyaSethi @brotherlymite
GHO CCIP 1.5 Maintenance Upgrade (#512)
c016f11 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: install aave-ccip at latest commit on aave/ccip#18

* chore: upd remappings, lib/aave-helpers, .assets

* new: add proposal for eth & arb

* fix: arb test supply locked invariant

* fix: rename, add discussion link

* upd: aave-ccip module

* feat: add proxy pool deployments

* feat: add e2e tests

* chore: fix license, explicit senders for expectEmit

* ci: override rpc url in secrets

* test: proxy pool can off ramp

* chore: reorder deps

* nit: utilize existing ierc20 import, style guide, use arb assets for gho addy

* feat: add rate limit, use gho fascilitator for tests

* feat: set in bound rate limit as well

* chore: cleanup

* test: check proxy initialized version

* chore: inBetween => inFlight"

* chore: test name consistency

* test: dynamically fetch dest gas amt

* test: execMsg post migration using legacy off ramp

* test: ccip steward can disable rate limit

* chore: cleanup

* doc: add comment for fetching all offramps, use RISK_COUNCIL for clarity

* test: ownership transfer after migration

* chore: rm _readRiskAdmin, fix config

* fix: ci test setup to stay compatible with bdg upstream

* feat: rm aave-ccip dep

* rft: use deployed token pools

* tmp: fix ci for aave org, to rm for bdg

* fix: ci to bdg setup

* fix: update rate limit

* test: fuzz amounts

* chore: snapshot docs

* chore: const cap rate

* chore: fix type

* fix: Fix rate limit config constants

* fix: tests, impl correct solc

* fix: tests

* Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Ethereum_GHOCCIP150Upgrade_20241021.sol

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021.sol

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* doc: reference token pool contracts

* doc: upgrade spec

* doc: formatting

* Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md

Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>

* Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md

Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>

* test: Refresh block number with ghostewards aip executed

* fix: Remove unneeded script

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: DhairyaSethi <55102840+DhairyaSethi@users.noreply.github.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
brotherlymite pushed a commit that referenced this issue Jan 16, 2025
@DhairyaSethi @parth-15
@miguelmtzinf @CanonicalJP
GHO CCIP 1.5.1 Upgrade Eth<>Arb (#557)
134c39c 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* chore: init aip

* feat: ccip 1.5.1 upgrade

* tmp: fix ci for aave org, to rm for bdg

* tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed

* tmp: fix ci for aave org

* revert: test ci secrets updates

* chore: fix comments

* chore: rm duplicate check

* chore: reorder imports, pending automation

* chore: import order

* chore: imports order, re-frame comment

* feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment

* chore: consistency, cleanup comment based on latest approach

* upd: `directMint` & `directBurn`

* feat: add `gho-core` lib temporarily, fix interface

* feat: new gho ccip steward

* feat: reference existing pool upgrade impl deployment

* feat: more verbose and efficient

* chore: upd ccip lib

* test: cleanup & fuzzify

* test: cleanup & fuzzify

* chore: use latest deployment of existing remote pool upgrade

* doc: snapshot -> direct-to-aip

* chore: import gho from EthereumAssets instead of MiscEthereum

* chore: cleanup rm ProxyAdmin reference

* chore: rename facilitator

* chore: rm duplicate check

* fix: updates based on upstream changes from #527

* chore: fix&add comment, use chain selector from helper lib

* chore: fix chain selector lib typo

* feat: accept existing proxy pool ownership as well

* feat: add rate limit

* feat: add deployed token pools & stewards

* feat: rm `gho-core` & `ccip`

* feat: upd arb token pool & steward deployment

* feat: notify gho bucket steward

* feat: update aave steward

* chore: use existing IOwnable

* chore: new ccip stewards with timelock getter

* feat: use oz v5.1 proxies

* doc: add discussion + spec

* feat: chainlink pre-req have been performed

* Updated GHOCCIP151Upgrade.md

* Updated GHOCCIP151Upgrade.md

Updated to permalinks

* doc: lint and add steward addresses to spec md

* doc: expand on bucket steward update

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: JP <89362795+CanonicalJP@users.noreply.github.com>
sakulstra pushed a commit that referenced this issue Feb 5, 2025
@DhairyaSethi @parth-15
@miguelmtzinf @ianflexa
Gho Base Launch (#579)
dd89fe2 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* chore: init aip

* feat: ccip 1.5.1 upgrade

* tmp: fix ci for aave org, to rm for bdg

* tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed

* tmp: fix ci for aave org

* revert: test ci secrets updates

* chore: fix comments

* chore: rm duplicate check

* chore: reorder imports, pending automation

* chore: import order

* chore: imports order, re-frame comment

* feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment

* chore: consistency, cleanup comment based on latest approach

* upd: `directMint` & `directBurn`

* feat: add `gho-core` lib temporarily, fix interface

* feat: new gho ccip steward

* feat: reference existing pool upgrade impl deployment

* feat: more verbose and efficient

* feat: base expansion

* chore: upd ccip lib

* test: cleanup & fuzzify

* test: cleanup & fuzzify

* chore: use latest deployment of existing remote pool upgrade

* doc: snapshot -> direct-to-aip

* chore: import gho from EthereumAssets instead of MiscEthereum

* chore: cleanup rm ProxyAdmin reference

* chore: rename facilitator

* chore: rm duplicate check

* fix: updates based on upstream changes from #527

* chore: fix&add comment, use chain selector from helper lib

* chore: upd ccip lib

* feat: expand _validateConfig in e2e test

* feat: eth & arb tests

* chore: import gho from EthereumAssets instead of MiscEthereum

* chore: use latest deployment of existing remote pool upgrade

* doc: snapshot & discussion

* chore: rename facilitator

* test: cleanup & fuzzify

* test: cleanup & fuzzify

* chore: use latest deployment of existing remote pool upgrade

* doc: snapshot -> direct-to-aip

* chore: import gho from EthereumAssets instead of MiscEthereum

* chore: cleanup rm ProxyAdmin reference

* chore: rename facilitator

* chore: rm duplicate check

* fix: snapshot, use utils reference for chain selectors

* fix: base config test on eth

* test: eth<>arb e2e test

* chore: mock naming accuracy

* feat: base token through create2

* feat: expand _validateConfig in e2e test

* feat: use deployed gho token impl on base, fix facilitator bucket to 20M instead of 25M

* fix: merge latest upstream

* chore: fix chain selector lib typo

* fix: tmp fix remappings such that gho-core OZ and aave-v3 OZ do not collide

* feat: stewards, base tests

* fix: use 500 maxChange borrowRateConfig

* feat: validate base proposal constants

* chore: add partial explorer links for immutables

* test: tokenPoolConfig

* feat: accept existing proxy pool ownership as well

* feat: add rate limit

* test: fix risk council

* fix: merge

* feat: add rate limit

* fix: riskCouncil

* feat: gho base listing

* feat: aave stewards test

* chore: fix typo

* chore: upd title

* feat: add deployed token pools & stewards

* feat: rm `gho-core` & `ccip`

* feat: upd arb token pool & steward deployment

* feat: use deployed base token pool & stewards

* feat: notify gho bucket steward

* feat: update aave steward

* upd: upstream

* chore: use existing IOwnable

* chore: steward tests

* fix: ccip stewards tests

* test: listing pre-req negative cases

* chore: minor cleanup

* test: verbose error msg

* feat: QoL cleanup

* chore: new ccip stewards with timelock getter

* chore: upd upstream

* chore: new ccip stewards with timelock getter on base

* feat: use oz v5.1 proxies

* upd: use latest eth/arb deployments

* feat: predeploy gho token

* doc: upd md with new token

* feat: update gho token proxyAdmin

* test: simplify

* chore: minor cleanup nits

* chore: resolve conflicts

* fix: update blocks, cleanup on pre-requisites

* doc: update AIP text

* test: 1.5.1 upgrade executed on chain, rm all prerequisites in tests

* test: upd base block since all pre req are complete

* chore: update spec md

Co-authored-by: Ian Flexa <85500650+ianflexa@users.noreply.github.com>

* fix: generate diff md again

* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* fix: rebase and update diffs, imports

* chore: import token pools from address book

* chore: fix lint on spec md

* fix: update rates based on latest recc

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: Ian Flexa <85500650+ianflexa@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
generator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sakulstra