Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ENH: Parallel specification of next API #999

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented May 2, 2023

Trying out some Protocols to start on #989 and get some feedback.

The goal is to shift this into bids, but for right now it's easier to use a separate package.

Some initial notes:

  1. Trying out putting get() back, but ensuring it only ever returns files.
  2. I'm using Dataset instead of Layout. I think that will help make a cleaner mental break, and could allow us to have both implementations in parallel for a while.
  3. We probably want to come up with different names for the protocols than the concrete classes. Will need to think about this. Open to suggestions.

@effigies effigies force-pushed the enh/pybids1-api branch from cde8511 to 6cc4457 Compare May 2, 2023 01:01
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (22d2eb5) 83.42% compared to head (bcddeb1) 83.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files          38       38           
  Lines        4290     4290           
  Branches     1100     1100           
=======================================
  Hits         3579     3579           
  Misses        515      515           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies force-pushed the enh/pybids1-api branch from 6cc4457 to bcddeb1 Compare May 2, 2023 12:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant