Configure CodeMirror to treat dataviewjs as javascript #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works, thank you |
|
Can also confirm that this works nicely. Thank you! |
src/main.ts
Outdated
| @@ -161,6 +161,11 @@ export default class DataviewPlugin extends Plugin { | |||
| }); | |||
| }) | |||
| ); | |||
|
|
|||
| window.CodeMirror.defineMode("dataviewjs", config => window.CodeMirror.getMode(config, "javascript")); | |||
There was a problem hiding this comment.
Might be worth noting that the codeblock-language should not be hardcoded, as the user can change it in the dataview settings (at least in theory, don't think there is a real reason to do so though)
There was a problem hiding this comment.
That's a very valid point. I'll make a fix for that
blacksmithgu
approved these changes
May 26, 2024
|
Neat! |
|
hooray |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #566