Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Configure CodeMirror to treat dataviewjs as javascript #2329

Merged
merged 3 commits into from
May 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,21 @@ export default class DataviewPlugin extends Plugin {
});
})
);

this.registerDataviewjsCodeHighlighting();
this.register(() => this.unregisterDataviewjsCodeHighlighting());
}

public registerDataviewjsCodeHighlighting(): void {
window.CodeMirror.defineMode(this.settings.dataviewJsKeyword, config =>
window.CodeMirror.getMode(config, "javascript")
);
}

public unregisterDataviewjsCodeHighlighting(): void {
window.CodeMirror.defineMode(this.settings.dataviewJsKeyword, config =>
window.CodeMirror.getMode(config, "null")
);
}

private debouncedRefresh: () => void = () => null;
Expand Down Expand Up @@ -379,7 +394,9 @@ class GeneralSettingsTab extends PluginSettingTab {
.setValue(this.plugin.settings.dataviewJsKeyword)
.onChange(async value => {
if (value.length == 0) return;
this.plugin.unregisterDataviewjsCodeHighlighting();
await this.plugin.updateSettings({ dataviewJsKeyword: value });
this.plugin.registerDataviewjsCodeHighlighting();
})
);

Expand Down
Loading