-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update bitdrift to 0.6.7 and enable iOS network integration #7575
update bitdrift to 0.6.7 and enable iOS network integration #7575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see bluesky using bitdrift :) I don't see the android plugin added for network instrumentation, so I left a small suggestion to make the init config more clear.
Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com>
…nto update-bitdrift-0.6.5
I bumped this up to 0.6.7 since that includes a fix to the new iOS swizzling logic |
1ffdd66
to
355c50f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Gonna merge this and #7725 into a base and build some tests from there.
* update bitdrift to 0.6.5 and enable iOS network integration * Update src/lib/bitdrift.ts Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com> * update to 0.6.7 --------- Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com>
* update bitdrift to 0.6.5 and enable iOS network integration * Update src/lib/bitdrift.ts Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com> * update to 0.6.7 --------- Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com>
* update bitdrift to 0.6.7 and enable iOS network integration (#7575) * update bitdrift to 0.6.5 and enable iOS network integration * Update src/lib/bitdrift.ts Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com> * update to 0.6.7 --------- Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com> * deps: Bump bitdrift to 0.6.8, fixes iOS network instrumentation bug (#7725) Co-authored-by: Eric Bailey <git@esb.lol> * Add stable ID copy, add todo * Nits * Temp enable * Temp debug * Revert some debug * Revert unnecessary change * Use new gates * Add anon ID to version string --------- Co-authored-by: Snow Pettersen <snowp@lyft.com> Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com>
This updates the bitdrift library to 0.6.7, which brings in a new version of the Capture SDK that addresses the limitations with the iOS networking integration that caused it to not play well with the bluesky app.