-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bitdrift integration #7728
Merged
Merged
Bitdrift integration #7728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
surfdude29
reviewed
Feb 12, 2025
* update bitdrift to 0.6.5 and enable iOS network integration * Update src/lib/bitdrift.ts Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com> * update to 0.6.7 --------- Co-authored-by: Mark <40143016+Maker-Mark@users.noreply.github.com>
…7725) Co-authored-by: Eric Bailey <git@esb.lol>
e3da93b
to
7ad3db8
Compare
mozzius
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not up to date on bitdrift so idk what I'm testing, but it builds np so lgtm
estrattonbailey
added a commit
that referenced
this pull request
Feb 17, 2025
* origin/main: Make Android app start faster by disabling JS bundle compression (#7751) Nightly source-language update Update tests Screen for searching user's posts (#7622) Add translations missed in last PR (#7748) 1.98 release: Pull latest from crowdin (#7746) [Instrumentation] Signin (#7742) Reenable router events (#7735) Nightly source-language update Bitdrift integration (#7728) Use effective filtering for feeds (#7736) Update PostInteractionSettingsDialog.tsx (#7726)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes two PRs relating to version bumps, which puts us at the latest version.
This PR then integrates two new feature flags:
enable_bitdrift_v2
which replaces the initial flagenable_bitdrift_v2_networking
which conditionally enables network logging (which caused a bug previously)Decided to replace the initial flag so that as we ramp this new version, we don't ramp older clients that are still using the old version of the Bitdrift library.
Tested on TF and APK. Web should have no changes.