Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add copy clean link to the macOS application menu bar #26825

Closed
fmarier opened this issue Nov 17, 2022 · 1 comment · Fixed by brave/brave-core#16274
Closed

Add copy clean link to the macOS application menu bar #26825

fmarier opened this issue Nov 17, 2022 · 1 comment · Fixed by brave/brave-core#16274

Comments

@fmarier
Copy link
Member

fmarier commented Nov 17, 2022

The new "copy clean link" option is available in the contextual menu on macOS:
copy-clean-url1

but it should also be available in the application menu bar where the keyboard shortcut can be seen:
copy-clean-url2

(The keyboard shortcut is being changed to clean URLs by default in #26761.)

@stephendonner
Copy link

stephendonner commented Feb 14, 2023

Verification PASSED using

Brave 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Case 1: URL selection

Steps:

  1. installed 1.49.96
  2. launched Brave
  3. loaded https://twitter.com/fmarier/status/1574869891978784769?s=21&t=lkfjeslkfjes&fbclid=1234
  4. selected the URL
  5. clicked on the top-level macOS Edit application-menu item
  6. examined the shortcut options

Confirmed I got Copy Clean Link ⌘C

Screen Shot 2023-02-13 at 4 18 44 PM

Case 2: substring selection

(continued from Case 1)

  • selected substring fmarier/status/1574869891978784769
  • clicked on the top-level macOS Edit application-menu item
  • examined the shortcut options

Confirmed regular Copy ⌘C menu item

Screen Shot 2023-02-13 at 4 28 49 PM

Case 3: no selection

  • with no selection, clicked on the top-level macOS Edit application-menu item
  • examined the shortcut options

Confirmed regular Copy ⌘C menu item

Screen Shot 2023-02-13 at 4 30 11 PM

# for free to join this conversation on GitHub. Already have an account? # to comment