Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

wip: Add copy clean link to the macOS application menu bar #16426

Closed
wants to merge 1 commit into from

Conversation

spylogsster
Copy link
Contributor

Resolves brave/brave-browser#26825

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Select URL in the url bar and open Mac menu, the copy clean link item should be visible in the menu
  • Remove selection or select a text(not url), the copy clean link item should NOT be visible in the menu

@spylogsster spylogsster requested a review from a team as a code owner December 20, 2022 11:31
@spylogsster spylogsster self-assigned this Dec 20, 2022
@spylogsster spylogsster marked this pull request as draft December 20, 2022 11:31
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Dec 20, 2022
@spylogsster spylogsster force-pushed the brave-26825-menu-only branch from 27c81c7 to 09d94ed Compare December 20, 2022 11:43
@spylogsster spylogsster deleted the brave-26825-menu-only branch December 20, 2022 11:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copy clean link to the macOS application menu bar
1 participant