Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[iOS] - BraveVPN crashes if purchasing Leo AFTER VPN #42268

Closed
3 of 5 tasks
Brandon-T opened this issue Nov 13, 2024 · 2 comments · Fixed by brave/brave-core#26528
Closed
3 of 5 tasks

[iOS] - BraveVPN crashes if purchasing Leo AFTER VPN #42268

Brandon-T opened this issue Nov 13, 2024 · 2 comments · Fixed by brave/brave-core#26528
Assignees
@Brandon-T
Labels
browser-ai feature/vpn OS/iOS Fixes related to iOS browser functionality premium All issues related to Brave Premium QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.73.x - Release #2

Comments

@Brandon-T
Copy link

Description

  • When a user purchases Leo AFTER purchasing VPN, if the user goes to VPN settings, it will crash

Steps to reproduce

  1. Purchase VPN
  2. Purchase Leo
  3. 3-dot menu -> Settings -> Brave VPN

Actual result

  • Crash

Expected result

  • Should not crash

Reproduces how often

Easily reproduced

Brave version

  • 1.62+

Device/iOS version

  • iPhone

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@Brandon-T Brandon-T added OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude labels Nov 13, 2024
@Brandon-T Brandon-T self-assigned this Nov 13, 2024
@Brandon-T Brandon-T mentioned this issue Nov 13, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 14, 2024
This was referenced Nov 14, 2024
Merged
Merged
@kjozwiak kjozwiak added feature/vpn premium All issues related to Brave Premium browser-ai labels Nov 15, 2024
@kjozwiak
Copy link
Member

The above requires 1.73.90 or higher for 1.73.x verification 👍

@kjozwiak kjozwiak mentioned this issue Nov 18, 2024
Closed
20 tasks
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 18, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone XR running iOS 17.7.1 using version 1.73 (90)

Leo Brave VPN
Image Image

@Uni-verse Uni-verse added QA Pass - iPhone X and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 18, 2024
@Uni-verse Uni-verse mentioned this issue Dec 6, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Brandon-T Brandon-T

Labels
browser-ai feature/vpn OS/iOS Fixes related to iOS browser functionality premium All issues related to Brave Premium QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.73.x - Release #2
Development

Successfully merging a pull request may close this issue.

[iOS] - Fix VPN crashing if you purchase Leo AFTER VPN. brave/brave-core
4 participants
@Brandon-T @kjozwiak @Uni-verse @brave-builds